Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Disallow "deleted" acq units from being assigned to invoices

Description

Overview

introduces a "isDeleted" flag to the acquisition unit. While there currently aren't any plans systematically go through and remove assignments to units when they are marked "deleted", These units should not be assignable.

Acceptance Criteria

  • "deleted" acquisition units cannot be assigned to records

  • Unit tests are updated

  • API tests are updated

Open issues

  • How should we handle this in the context of editing assignments? If a record is updated (something not related to acq. units is being changed) and one of the units assigned to this record was marked "deleted" since it's last update, should we force the user to remove that assignment? Do it for them? Leave it as is?

    • [Resolved] For now we've chosen to leave these as is.

Environment

None

Potential Workaround

None

Attachments

4

Checklist

hide

TestRail: Results

Activity

Show:

Craig McNally September 23, 2019 at 5:58 PM
Edited

Verified on folio-testing:

Create an acqUnit w/ isDelete = true

Try to assign that acqUnit to an existing invoice - should fail

Try to assign that acqUnit to a new invoice - should fail

Assign another acqUnit to a new invoice (not deleted), then delete it after the assignment has been made. The invoice should retain the acqUnit assignment

Craig McNally September 23, 2019 at 5:46 PM

Verified API tests on folio-testing:

Craig McNally September 23, 2019 at 3:43 PM
Edited

Possibly unrelated to these changes - I'm having a hard time verifying this in the hosted reference envs as it appears mod-invoice may be crashing. I'm working with devops to investigate and resolve now.

if we can't get this sorted out soon this story might have to spill over into Sprint 73.

Varun Javalkar September 17, 2019 at 8:07 PM

Verified via API tests PR#309

Varun Javalkar September 17, 2019 at 3:12 PM

Verify update of soft-deleted unit in folio-testing:
1. Create 2 acquisition units:

Response

Response

2. Delete unit 2

3. GET soft deleted unit and verify that isDeleted is true

Response

4. Update soft-deleted unit

Response

5. Get unit and verify soft-deleted unit was updated

Response

6. Delete both units from storage 

Done

Details

Assignee

Reporter

Tester Assignee

Priority

Story Points

Sprint

Development Team

EBSCO - FSE

Parent

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created August 5, 2019 at 7:05 PM
Updated September 23, 2019 at 6:06 PM
Resolved September 23, 2019 at 6:06 PM
TestRail: Cases
TestRail: Runs