Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

LedgerFY records for past years

Description

Overview

This was observed on the start of a new year. For the existing sample data with FY records only for FY18 and FY19, there was no ledgerFY record present. Hence the insertion of transaction records was failing with ledgerFY record not being present.

We need to handle the scenario of making the ledgerFY record available for past years.
Currently we are creating ledgerFY records for FYs where, periodEnd > now

Approach

Upon creation of a fiscal year, check if there any ledgers using that FY series. If so, create a ledgerFY record, regardless of the periodEnd value.

Upon creation of a ledger, create ledgerFY records for each FY in the series, regardless of whether they're in the past, present or future.

Acceptance Criteria

  • LedgerFY records are always created as needed (upon FY and Ledger creation)

  • Unit tests are updated

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Siarhei HrabkoApril 30, 2020 at 11:33 AM

Verified on folio snapshot
1. Test that ledgerFY records are created for each FY in the series

Create initial FiscalYear and Ledger

Appropriate ledgerFY record created:

Create three FiscalYears (past, present, future) with same series:

Appropriate ledgerFY records created:

Create three FiscalYears (past, present, future) with "QFY" series:

ledgerFY records quantity remains unchanged:

Siarhei CharniakApril 17, 2020 at 1:18 PM
Edited

Verified on folio-testing:

1. Test that ledgerFY records are created only for each FY in the series

Create initial FiscalYear and Ledger

Appropriate ledgerFY record created:

Create three FiscalYears (past, present, future) with same series:

Appropriate ledgerFY records created:

Create three FiscalYears (past, present, future) with "QFY" series:

ledgerFY records quantity remains unchanged:

2. Test that ledgerFY records are created for all FY in the series upon ledger creation

Create three FiscalYears (past, present, future) with same series:

Create a ledger:

ledgerFY records created for each fiscal year:

3. Test that ledgerFY records aren't created for FY not in the series

Create a FiscalYear with "FY" series:

Create three FiscalYears (past, present, future) with "QFY" series:

Create a ledger for "FY" series FiscalYear:

Check that ledgerFY record is created for "FY" series FiscalYear only:

Craig McNallyJanuary 2, 2020 at 8:48 PM
Edited

I think it was that we just assumed that we were assuming that ledgerFYs would already exist if periodEnd <= now. I think this is as simple as adjusting that to create one, regardless of the periodEnd value.

Craig McNallyJanuary 2, 2020 at 8:44 PM

I honestly can't remember why we're only creating ledgerFY records for ledgers in the future...

Done

Details

Assignee

Reporter

Tester Assignee

Labels

Priority

Story Points

Sprint

Development Team

Thunderjet

Parent

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created January 2, 2020 at 3:48 PM
Updated April 30, 2020 at 11:33 AM
Resolved April 30, 2020 at 11:33 AM
TestRail: Cases
TestRail: Runs