Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Remove the old transaction API

Description

Purpose/Overview:

After the old endpoints were deprecated in https://folio-org.atlassian.net/browse/UXPROD-4321#icft=UXPROD-4321 for Quesnelia, implementation can be removed in a major version change for another release.

Requirements/Scope:

  • Remove the following endpoints and related implementations:

    • /finance/encumbrances

    • /finance/payments

    • /finance/pending-payments

    • /finance/credits

    • /finance/order-transaction-summaries

    • /finance/invoice-transaction-summaries

  • Reimplement the following using the batch API internally:

    • /finance/allocations

    • /finance/transfers

  • Update the tests as needed

Approach:

Remove the endpoints, the implementations, the tests, and refactor as needed.

It is possible integration tests will need to be updated.

Acceptance criteria:

  • Endpoints removed

  • Unit tests and integration tests pass

Environment

None

Potential Workaround

None

Attachments

3
  • 18 Apr 2024, 08:20 AM
  • 18 Apr 2024, 08:20 AM
  • 18 Apr 2024, 08:20 AM

Checklist

hide

TestRail: Results

Activity

Show:

Serhii_Nosko April 22, 2024 at 5:56 AM

The main work has been done in scope of this PR: https://github.com/folio-org/mod-finance/pull/245

Karate tests passed after this refactoring, going to close this story.

Damien April 18, 2024 at 12:39 PM
Edited

Thanks, this looks like a bug. The “finance-storage.funds.collection.get" permission is missing for "/finance/transactions/batch-all-or-nothing", I added it with this PR.

Ihor Bohdan April 18, 2024 at 8:20 AM

When I transfer budget from one fund to another, i have an eror.

Screenshot_528.png

 

Screenshot_527.png

 

Screenshot_526.png

Damien April 16, 2024 at 3:55 PM
Edited

Nothing should change from a UI perspective. The operations that would be the most likely to break are creations of allocations and transfers, so I guess we could check that for review. Also, this should probably be reviewed together with https://folio-org.atlassian.net/browse/MODFISTO-460.

Done

Details

Assignee

Reporter

Labels

Priority

Sprint

Development Team

Thunderjet

Fix versions

Release

Ramsons (R2 2024)

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created February 2, 2024 at 4:03 PM
Updated April 29, 2024 at 3:12 PM
Resolved April 22, 2024 at 5:56 AM
TestRail: Cases
TestRail: Runs

Flag notifications