Adding MARC modifications to single record overlay doesn't respect field protections

Description

Overview: When a marc modification action is added to the end of the single record overlay job, protected fields from the existing marc srs are removed rather than from the incoming file.

Steps to Reproduce:

  1. Log into some FOLIO snapshot environment 

  2. Go to Settings/Data Import

  3. Duplicate the field mappings for Inventory Single Record - Default for the update marc bib and update instance

  4. Create a new field mapping for a marc modification where the fields 029, 506, 856, 583 are deleted

  5. Create action profiles linked to the field mappings you just created

  6. Duplicate the inventory single record match for no srs and existing srs

  7. In field protections, make sure that you add 583 with subfield 5 and data MU in addition to 856 with subfield 5 and data MU.

  8. Create a job with a match to existing marc srs. On matches update marc srs. On no matches, another match to no srs and then under that update instance. Then at the level of the 1st match, add the modify marc action (see screenshot)

  9. Bring in a record and add a 583 with a $5 MU and a 856 $5 MU

  10. Overlay

Expected Results: The existing and protected fields should remain in the record.

Actual Results: The protected fields have been removed.

Additional Information:
URL: The job profile on orchid bugfest is https://bugfest-orchid.int.aws.folio.org/settings/data-import/job-profiles/view/b590fc78-f069-42a1-bfdd-3988c7d6be00?query=fc%20test&sort=name. 

Interested parties:

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

4
  • 23 Aug 2023, 01:31 PM
  • 23 Aug 2023, 01:30 PM
  • 23 Aug 2023, 01:26 PM
  • 23 Aug 2023, 01:26 PM

Checklist

hide

TestRail: Results

Activity

Show:

Kateryna Senchenko June 27, 2024 at 12:58 PM

MARC Modification action should not take into account field protection settings - such were original requirements and we have test rails that explicitly test that
https://foliotest.testrail.io//index.php?/cases/view/350678
https://foliotest.testrail.io//index.php?/cases/view/359188

Supported scenarios for using MARC Modify are described here - https://folio-org.atlassian.net/wiki/spaces/DD/pages/1778826/3.+Modify+MARC+BIB

, please review the user documentation contains details about Modify action and and fields protections. I believe this issue could be closed as not a bug. Thank you!

Jaleh Fazelian June 17, 2024 at 2:24 PM

FROM SUPPORT: Thank you for providing more information. can you respond and explain why the ticket remains blocked? Thanks

Jennifer Eustis May 28, 2024 at 12:20 PM
Edited

Hi , when I put the marc modification for a marc srs update at the beginning of the job and before the match, the field protections (in my one test) were respected. I would say this is a good sign. It seemed from our discussions that no one could think of needing to have a marc modification at the end or after an update marc action. Perhaps the flow is that on update the marc modification has to come first?? If we stick to that and a few more tests to make sure that this flow respects field protections, would it be possible to close this out? And this would apply to Quesnelia as this is when the new flow of where to put marc modifications starts.

Charlotte Whitt May 27, 2024 at 2:34 PM

Support SIG: please update the ticket with the outcome of the conversation in the DI working group, as mentioned above. I assume this ticket is blocked on that conversation, while we don’t see any tickets listed as blocking work.

If this conversation states that all is good, then please close the ticket.

Jennifer Eustis May 6, 2024 at 3:42 PM
Edited

, I just tested this in bugfest quesnelia and it is working. I’ll do a couple of more tests. The first test that I did was a job profile that was part of the SRI update instance. This worked.

However, when I use this same marc modification profile to update an instance, the protected fields are stripped from the existing record. See job https://bugfest-quesnelia.int.aws.folio.org/data-import/job-summary/bb20e0ff-826c-4a1d-9740-7141581ded8f and https://bugfest-quesnelia.int.aws.folio.org/data-import/job-summary/7584a479-3049-4927-af99-3980edebb6e5

I ran another version where instead of putting the marc modification at the end of the profile or after the update instance action, I put it in front of the match as the first action in the job for the solo job profile to update the instance. This preserved the field protections. https://bugfest-quesnelia.int.aws.folio.org/data-import/job-summary/6d15e02c-03d0-4c4f-aa3d-77f8ab804c53

We’ll be talking about MARC modifications this week in DI working group. I would prefer to hold off until we have that discussion where I’ll bring this up.

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Folijet

Release

Ramsons (R2 2024)

RCA Group

Requirements change

Affected releases

Poppy (R2 2023)
Orchid (R1 2023)

Affected Institution

5 Colleges

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created August 23, 2023 at 1:25 PM
Updated July 23, 2024 at 2:49 PM
Resolved July 23, 2024 at 2:49 PM
TestRail: Cases
TestRail: Runs