quickMARC: Keep the user's focus when user hits Save & keep editing

Description

Overview:
When a user is editing a record in quickMARC and clicks "Save & keep editing" they are returned to the top of the record, rather than staying at the line they were editing. The browser page refreshes and they lose their place. See https://folio-project.slack.com/archives/C20V5L40P/p1691602925850099 for a library's description of the problem.

Steps to Reproduce:

  • Log in to FOLIO snapshot as diku_admin

  • Go to a record with source = MARC

  • Edit a MARC bib/authority/holdings record

  • Make a change (add/edit/delete a field), and then click "Save & keep editing"

Expected Results: Focus should return/remain on the last text box or action that was in focus before user hit the Save & keep editing button.

Actual Results: The page refreshes and the user is returned to the top of the screen.

Interested parties: Holy Cross, Library of Congress

Environment

None

Potential Workaround

None

Attachments

3

Checklist

hide

Activity

Show:

Khalilah Gambrell November 2, 2024 at 2:05 PM

Works as noted in requirements. Will write additional stories related to

  • Inline errors focus

  • Modal focus handling

Valery_Pilko October 31, 2024 at 4:02 PM

Tests are updated according to clarification. Ready for PO review.

Khalilah Gambrell October 31, 2024 at 12:49 PM

Case 3 = Works as expected
Case 8 and 10 = KG to create a story for handling modals and return to focus

Case 12 = Works as expected

Valery_Pilko October 25, 2024 at 4:19 PM

Tested on Sprint testing environment for MARC bib, MARC authority, MARC holdings records:

Case 1 - user updates subfield of any field - works as expected.
Actual result: Focus stays in the last updated field.
See attached screencast:

Case 2 - user updates any field - works as expected.


Actual result: Focus stays in the last updated field (MARC tag box)
See attached screencast:

Case 3 - user updates any indicator box - question.
Actual result: Focus stays in the last updated indicator box, but value is highlighted. Should we fix it?
See attached screencast:

Case 4 - user updates position of “008” field - works as expected.
Actual result: Focus stays in the last updated position.
See attached screencast:

Case 5 - user updates position of “LDR” field - works as expected.
Actual result: Focus stays in the last updated position.
See attached screencast:

Case 6 - Move icons - works as expected.
Actual result: Focus stays in the last clicked arrow icon
See attached screencast:

Case 7 - Delete field - works as expected.
Actual result: Focus stays on the moved down icon placed next to deleted field
See attached screencast:

Case 8 - Update 1XX of linked MARC authority record - Question
Actual result: Focus doesn’t stay in 1XX field after saving. Should we fix it?
See attached screencast:

Case 9 - Update Location of MARC holdings record - works as expected.
Actual result: Focus stays in “Permanent location look-up
See attached screencast:

Case 10 - Link MARC bib field with MARC authority - Question: Where should focus go?
See attached screencast:

Case 11 - Edit editable boxes of linked MARC bib field - Works as expected.
Actual result: Focus stays in edited box.
See attached screencast:

Case 12 - Perform some update >> move focus to another (not edited) field >> Click on the “Save & keep editing - Question, is it expected to leave focus in not updated field in this case?
See attached screencast:

 

Hi - please review cases marked with Questions and provide expected results for them. And if you see some other cases, please share.

Dmytro Melnyshyn October 15, 2024 at 12:42 PM

Hey - when we save a record, for optimistic locking we check instance._version from inventory/instances/id. Does this guarantee that fields from records-editor/records?externalId=id were not updated too and we don’t need to request fields again? In the current implementation, we request fields again after saving the record and it interferes.

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Spitfire

Fix versions

Release

Ramsons (R2 2024)

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created October 11, 2024 at 1:39 PM
Updated November 25, 2024 at 3:49 PM
Resolved November 2, 2024 at 2:05 PM
Loading...