Pipelines to build repositories which only have a dockerfile

Description

I believe the build pipelines presently assume that there’s a pom.xml (or equivalent for gradle, etc.). However, for repositories which only have a dockerfile (e.g. folio-keycloak, folio-kong), we still need the job to build these images and publish them to dockerhub, etc.

Please coordinate with Kitfox team. It looks like they may have put something in place which publishes the docker images somewhere else.

Environment

None

Potential Workaround

None

Checklist

hide

Activity

Show:

David Crossley November 27, 2024 at 2:31 AM
Edited

This is now fixed. See https://github.com/folio-org/.github/pull/68

Note that the same workflow to obtain the version-number is used for these Docker-only Workflows and for the Go-based Workflows, and will be used for the upcoming Maven-based Workflows.

Thanks to Zak and Malc for attempts to test and diagnose.

We had tried various stuff such as doing "fetch-tags: true" during the checkout step, all to no avail.

The problem was related to https://github.com/actions/checkout/issues/1467 -- Can't fetch with fetch-tags when triggered by tag

Wandering through the comments revealed two solutions:

One was to do "fetch-depth: 0" during checkout, i.e. crudely "0 indicates all history for all branches and tags". But that would be cumbersome for some repositories that have an outrageous number of branches FOLIO-3346.

The other solution (which we implemented) is to follow after the "checkout" to "Fetch git tags". We were previously doing that, but instead we need to also force and prune tags. Many thanks to "sodel" at https://github.com/actions/checkout/issues/1467#issuecomment-1809379916 and see their commit immediately prior to that link.

Not seen at the UI-related Workflows because they calculate the version numbers for release and snapshot by inspecting package.json file. Whereas for these Workflows we need to calculate based on the most-recent git tag.

The follow-up GitHub Workflow runs for their recent tag at folio-keycloak and folio-kong and mod-reporting were successful.

David Crossley November 23, 2024 at 2:10 AM

Re-opened this ticket, Zak also had failure at folio-keycloak v25.0.6 release.

Refer to Slack discussion at #devops 2024-11-23

David Crossley November 4, 2024 at 4:12 AM

I see that there was a failure of the GitHub Workflow for folio-kong with the recent release by yauhen-vavilkin. (And similarly a failure at folio-keycloak.)

The previous folio-kong release v3.7.2 by dmtkachenko was successful -- the Workflow ran properly.

I wonder if there is something amiss with the technique used by yauhen-vavilkin to apply git tags.

There is no tag for v3.7.3 shown at https://github.com/folio-org/folio-kong/tags -- the most recent is v3.7.2 on 2024-10-02

Yet the Workflow run on 2024-11-02 was triggered because it detected a git tag v3.7.3

Please ask those two developers to compare their technique for applying git tags.

(Note that the recent release of mod-reporting also had no such troubles with its Workflow, which uses the same methods.)

David Crossley October 2, 2024 at 7:15 AM

Fixed.

David Crossley October 2, 2024 at 12:24 AM

Re-opened, as the Workflow did not run on the recent release of folio-keycloak, i.e. the first release since the last fix attempt.

Done

Details

Assignee

Reporter

Priority

Sprint

Development Team

FOLIO DevOps

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created August 5, 2024 at 9:00 PM
Updated November 27, 2024 at 3:29 AM
Resolved November 27, 2024 at 2:31 AM
TestRail: Cases
TestRail: Runs