Agreements - Edit: add spacing above repeating group buttons
Description
Attachments
defines
relates to
Checklist
hideTestRail: Results
Activity
Gill Osguthorpe November 25, 2019 at 1:13 PM
Hi . I've mentioned this change to and he asked that I talk to you so that it can be made centrally. The upshot is that the repeating group cards need a bottom margin applying in order to add separation between each other and other components such as buttons. has already done some work on this.
Ethan Freestone November 22, 2019 at 12:47 PM
I've put PRs in now for ui-agreements and stripes-erm-components. As I say there may be knock on effects for the generic component, so I'm happy to make the hasMargin conditional if it's going to break established things elsewhere.
Ethan Freestone November 21, 2019 at 1:33 PM
For now I've added a simple `hasMargin` to most of the fields above, mimicking the model in Organisations. It shouldn't be too much effort to go back and only render that on the final card though. However, External licenses and Supplementary Info use `DocumentsFieldArray`, a stripes-erm-component, so any decision made here will have knock on effects elsewhere, and I've left that file alone for now because I'm not sure what I do/don't have allowances to mess with.
Owen Stephens November 20, 2019 at 3:21 PM
Need to decide whether Internal Contacts or Organisations is the right model
Details
Details
Components
Assignee
Gill OsguthorpeReporter
Gill OsguthorpeLabels
Priority
TBD
In the Agreement Edit pane where a repeating group button is displayed, there should be some space between it and the element above it, as shown in the below screen snip of the "Add organization" button.
Buttons which require space adding above are:
Add agreement period
Add agreement line
Add PO line
Add custom coverage
Add license
Add external license
Add supplementary information
Add usage data provider
Add related agreement
NOTE: The margin should be added to the bottom of the card and not the button. This will also benefit the layout through the introduction of vertical spacing between repeating group cards.