Overdue fine not calculated properly for migrated overdue item

Description

Overview:
Holly just met with Anne Highsmith of Texas A&M to review an issue Anne has uncovered with the calculation of overdue fines on a migrated overdue item. The meeting recording is available at https://drive.google.com/open?id=10OUlIB7VbYWg0DOklo_-QmJhYOH-XjlH
The recording explains the situation, shows the policies in effect, the calendar, etc. We also wanted to test the calculation of overdue fines on a loan that originated in FOLIO, but we couldn't due to a system error. We will try that again after the system error is fixed.

Steps to Reproduce:

  1. Migrate an overdue Voyager loan to FOLIO

  2. The loan we are testing with was due on December 10, 2018 at 6:11 PM (very overdue!)

  3. Log into TAMU's FOLIO test environment (Anne will request a special login for the developer who investigates this issue)

  4. Check in the overdue book on May 29, 2020 at 2:36 PM

  5. The check-in page indicates that a fee/fine was charged

Expected Results:
35.00 fee/fine charged (overdue fine is 1.00 per day, with a maximum of 35.00)

Actual Results:
9.00 fee/fine charged

Additional Information:

  • TAMU does not count closed time in overdue fines

  • TAMU has installed the most recent hotfix related to not counting closed time (mod-circulation-18.0.9)

  • TAMU's calendar begins on January 1, 2000, and they are open every day

  • When the test was rerun, with a check-in on June 2, 2020, the fee/fine was still 9.00. We would have expected it to be higher.

  • The loans were migrated into FOLIO about a week ago

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

2

Checklist

hide

TestRail: Results

Activity

Show:

Holly MistlebauerJuly 1, 2020 at 10:25 PM

Holly tested this on https://bugfest-fameflower.folio.ebsco.com/ and https://bugfest-goldenrod.folio.ebsco.com/ and it works as expected. Thanks much!

Darcy BranchiniJune 30, 2020 at 4:04 PM

Awesome , thank you! Will you get the Fameflower hotfix approved on the release_bug_triage channel?

Holly MistlebauerJune 30, 2020 at 3:58 PM

I didn't release I could change a due date back to December 10, 2018...interesting...well, this is tested and ready for release to Fameflower bugfest for testing with ...it will also need to be released to Goldenrod bugfest for testing...thanks...

Holly MistlebauerJune 30, 2020 at 3:40 PM

O.k. I thought the bug was related to the migration in some way.

Roman BarannykJune 30, 2020 at 1:52 PM
Edited

I had managed to reproduce this issue on snapshot before this fix was implemented.
I followed the scenario that you described above:

1. The loan we are testing with was due on December 10, 2018 at 6:11 PM
2. I created library hours working hours for the same service point, e.g. mon,tue,wed,thu,fri 8.00 am - 18.00 pm (Valid From: 1.01.2020)
3. Configured Overdue fine policy:
Overdue fine
1.00 per day

Count closed days/hours/minutes
No

Maximum overdue fine
35.00

After check-in 35.00 fee/fine should be charged (9.00 fee/fine had been charged before I fixed this bug)

Done

Details

Assignee

Reporter

Tester Assignee

Priority

Story Points

Sprint

Development Team

Vega

Release

Q2 2020

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created June 2, 2020 at 3:52 PM
Updated July 1, 2020 at 10:25 PM
Resolved July 1, 2020 at 12:07 PM
TestRail: Cases
TestRail: Runs