Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Broken schedule notices records block notices processing

Description

Schedule notices queue is blocked by broken records (loanId doesn't exist, template doesn't exist, loan policy doesn't exist etc.)

1. Scheduled notices that have references to non-existing entities (loans, loan policies, templates, users) should be deleted in scope of Schedule processor flow
2. Tests should be added to cover flow with broken schedule notice records.

Table name - scheduled_notice
Method to start from - org.folio.circulation.domain.notice.schedule.DueDateScheduledNoticeHandler#handleDueDateNotice

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

1

Checklist

hide

TestRail: Results

Activity

Show:

Cate Boerema January 6, 2020 at 2:08 PM

Kostyantyn Khodarev December 9, 2019 at 11:04 AM


Initially i worked with real time notices only
For the notice you've created from scratch, possibly this notice was first-to-send, blocking entities had later nextRunTime.

Lisa Sjögren December 9, 2019 at 10:52 AM

I'm trying to wrap my head around something. A few days before you noticed these broken notice records, , I created a new non-real time patron notice policy from scratch - and for new loans referring to that policy, notices were being sent out. So either some scheduled notices were not blocked - or the "broken" notice records appeared and started blocking after scheduled notices were sent out on the 26th.

Here is an overdue notice sent out on November 26:

Kostyantyn Khodarev November 29, 2019 at 11:31 AM

Changed, thank you.
My understanding is CIRC-572 is intended to fix current issue on Chalmers env (clean up broken records and unblock notices queue)
This one - changes in logic to avoid situation with queue block in future

Marc Johnson November 29, 2019 at 11:24 AM

Is this issue the same as [CIRC-572]? If not, please could the title and description be expanded to explain how it is different and the impact.

Done

Details

Assignee

Reporter

Labels

Priority

Story Points

Sprint

Development Team

Vega

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created November 29, 2019 at 10:46 AM
Updated January 28, 2020 at 3:56 PM
Resolved January 3, 2020 at 10:07 PM
TestRail: Cases
TestRail: Runs