Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Incorrect data type for currency

Description

org.folio.circulation.domain.Account’s

method
public Double getRemainingFeeFineAmount() {
return representation.getDouble("remaining");
}

Double can’t be used for currency amounts

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Alexander Kurash February 1, 2022 at 1:20 PM

Not relevant anymore

Alexander Kurash February 1, 2022 at 1:19 PM

We're not using doubles for monetary values anymore. They can still be used for parsing/serialization on the way in or out of the module, but not for calculation purposes. In Account class we use FeeAmount for monetary values, which uses BigDecimal under the hood.

Holly Mistlebauer December 21, 2021 at 6:23 PM

FYI - This ticket has been blocked until the reporter confirms that it is still valid.

Holly Mistlebauer December 21, 2021 at 5:49 PM

: Please confirm that this very old ticket is still valid. If it is, please assign a Priority. If it isn't, please close this ticket as "Won't do". Thanks much...

Holly Mistlebauer December 8, 2021 at 9:40 PM

This ticket does not have a Priority set. In your opinion, what should the Priority be? Thanks for your help with this...

Won't Do

Details

Assignee

Reporter

Priority

Development Team

Vega

Parent

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created November 26, 2019 at 12:34 PM
Updated February 1, 2022 at 1:20 PM
Resolved February 1, 2022 at 1:20 PM
TestRail: Cases
TestRail: Runs