Move Recalls to Checked Out Items which Haven't Already Been Recalled
Description
Environment
Potential Workaround
Attachments
defines
has to be done after
is duplicated by
Checklist
hideTestRail: Results
Activity
Magda Zacharska July 24, 2019 at 6:03 PM
Works as expected.
Magda Zacharska July 24, 2019 at 6:02 PM
The notification were not sent because circulation rules that I created for this test were not included. After I updated circulation rules, the notifications are sent on the item checkout and on change of the due date. Recall receipt is sent only once one the recall is originally created but not when the request is moved.
For the second scenario no notices are sent.
Magda Zacharska July 24, 2019 at 2:22 PM
Testing in foliio-snapshot with mod-circulation-16.5.0-SNAPSHOT.341- I'm still not getting the notifications.
William Welling July 23, 2019 at 7:51 PM
PR to fix has been merged. Should be ready to test again tomorrow.
Cate Boerema July 23, 2019 at 5:35 PM
and I am going to re-open this because scenario 1 is failing. Without the notice to the current borrower, the whole workflow is problematic. Essentially, we are moving a recall and changing the due date on the current loan but not notifying the current borrower. This means the item will not be returned early and the current borrower will be surprised with an overdue when they bring the item in.
I updated the scenarios because the triggers have been renamed in Patron notices. The triggers are now labelled like this:
Recall - This will trigger a notice to the patron for whom the recall request was created
Due date change - This will trigger a notice to the patron that currently has the item on loan when the due date changes. This notice is working, I got an email when a recall was manually created on an item I had on loan. It's just not working when an existing recall is moved to the item I have on loan.
This is the patron notice policy I currently have setup in folio-testing:
Purpose: To implement a more complex scenario related to moving requests from one item to another (). The scope of this story is moving recalls to items that haven't already been recalled. This is more complex because it will need to change the due date on the current loan and send a notice.
User Story:
As a librarian who has moved a recall to an item that was not previously recalled
I want the current loan due date to be truncated and a recall notice to be sent to the current borrower
So they know to return the book early
Scenarios:
Scenario
Given Item X is Checked out AND has 0 recall requests in the request queue (so, since Chalmers is only using recalls, for them this would mean no requests on Item X)
When recall Request R is and is moved to Item X (anywhere in the queue)
Then:
Date date and time of existing loan should be modified using logic defined in
Patron notices should trigger as follows (when defined in policies and rules):
"-Recall - Requester- Recall" - These notices should NOT be sent
"-Recall - Loanee- Due date change" - These notices SHOULD be sent CB: While the due date has changed on the loan for this user, I am not receiving an email letting me know. I've waited 10 minutes now. Hopefully it's just taking a while...
Scenario
Given Item X is Checked out AND a recall request already exists in the queue
When recall Request R is and is moved to Item X (anywhere in the queue)
Then:
Date date and time of existing loan should NOT be modified
The following patron notices should NOT trigger as follows (when defined in policies and rules):
"-Recall - Requester- Recall"
"-Recall - Loanee- Due date change"
NOTE: Assumption is that the item the recall was previously on will not get its due date changed to give the time back or something (we may do this later)