mod-configuration - should it be deprecated or not?
mod-configuration has been discussed on the development channel recently. Developers like it because they can simply drop variables to the/configurations/entriesAPI. Simply use the "configuration.*" permission shared by all modules and you are done. No need to add schema validation, no need to add dedicated permissions, no need to add a dedicated API. Drawbacks:
A big institution need config write permissions with module granularity. One member of staff may be allowed to edit circulation config but not aquisition config.
No validation. mod-configuration cannot validate a POST or PUT request because it doesn't know. Only the module it belong to knows this. Relevant use case: Using curl/wget/postman/...
No documentation. mod-configuration has no documentation, one needs to search, maybe the module's README has some? A dedicated module API always publishes the API documentation athttps://dev.folio.org/reference/api/
Performance. Requests to mod-configuration result in latency. If the config API belongs to the module the module can cache it and can invalidate the cache if the config is changed. Caching requests to mod-configuration will always result in a time period with outdated values. In mod-inventory-storage we've combined fetching the HRID config and HRID generation into a single SQL query.
Coupling. Modules should be loosely coupled and therefore each module should store its own configs.
It was requested that a formalRFC/Architecture Decision Recordbeen created if mod-configuration should no longer been used for module-specific configurations.
Team decided we want to have this as a RFC. Target should be to have this implemented within Nolana. Could discuss in your meetings while the RFC process moves on.
We need to communicate the expectation better - e.g. add something to the platform release notes indicate how long P1 security issues will be backported to that release.
As long as we upgrade to the latest LTS release of Spring Boot in each flower release, we should be in decent shape - only ~1 mo. where we're running a version of Spring boot that's no longer supported.
Note that we're currently a bit behind with this, even if we upgrade edge modules, etc. in a Lotus HF, kiwi and Juniper will be running older, unsupported versions for some period of time. Going forward we'll need to be diligent about this to avoid getting into this situation again.
Update? Have we added anything to the MG release notes?
Not yet... Craig McNally will refresh his memory on what we agreed to at previous meetings and will send out a strawman message in the slack channel for review.
Textproposal:
Morning Glory will receive security fixes for critical issues until Orchid is released (est. Spring 2023). Detailed information on particular issues will be provided by the security team. With this release there will be no other security hotfixes on Kiwi.
Put this text proposal for the release into a ADR to forward this to the TC
Julian Ladisch to set up that ADR - This is done and has been reviewed by the TC
The TC has discussed this, and feel uncomfortable to make the call on their own. They feel that the PC needs to be involved in the decision.
The TC will revisit next week - stay tuned for next steps
The TC advised that we need to do some information gathering, engage those that made the LTS recommendations how we should proceed, as well as look at existing processes and policies to see if they are sufficient and can be adopted by the security team, or if there are gaps.
This was discussed at recent TC and PC meetings and the determination was that the Security team should engage Release Management on a case-by-case basis.
No real news here... Erin N. mentioned that she'll raise this with the staff at Duke. Maybe someone there can support these modules.
Let's give it another week and then we might consider to move this out of the folio repo since there is no maintainer
We asked Erin N. if there anything new on that
Still awaiting response from Duke (Erin).
Charlotte Whitt changed MODCR-81 status to "In progress" on 13/Jun/22.
No progress, not even for the "In progress" Jira MODCR-81 on July 7.
Today:
still no update
Kafka security
Team
The topic of Kafka security was raised as part of a conversation at the TC yesterday.
The Security Team should be aware of this and probably should weigh in on the topic, or even generate proposals if we have ideas for how to solve the problem.
There are several JIRAs on our board that haven't moved in a long time (well over a year in some cases...)
Do we want to possibly close these as won't do?
Craig McNally adjusted the base filter to sort by priority, then updated date, and also added a new quick filter to show only issues that haven't been updated in the last 90 days
Regarding file upload size issues (See
FOLIO-3317
-
Getting issue details...STATUS
), let's brainstorm ideas for mitigating the cumulative upload problem, not just he large file upload size problem.
Some APIs are more vulnerable to this than others, such as those not protected by permissions - e.g. mod-login, edge APIs, etc.
Action items
Julian Ladisch to update the docker best practices documentation on the FOLIO dev site