Recruitment Text
The FOLIO Reporting SIG is looking for people to serve on our Review Board for the FOLIO Analytics query repository. Members of the review board commit to monitoring submissions to the repository and sharing the responsibility of providing reviews for submissions that come in. Reviewing a submission involves checking over the SQL code for basic style and syntax issues and making sure the query runs without error on a test environment.
Members commit to serving on the review board for a single major ("flower") release of the FOLIO core software. We are currently recruiting reviewers for the Orchid release, expected to go live in April of 2023. Review board members may continue to serve for more than one release, if desired.
The review board will be made up of no fewer than five members. Other individuals who are not members of the review board can also volunteer to provide reviews, as time permits.
Reviewers ensure that contributions to FOLIO Analytics abide by the repository's guidelines for contributing. Contributors will contact the review board directly when there is a submission in need of review [using a dedicated FOLIO analytics review board channel on the LDP Slack]. Reviewers will outline any necessary changes clearly and communicate them to contributors in a timely manner.
Expected time commitment: [???] hours per week
Members of the review board will be recruited until the five spots are filled. An optional training will be scheduled when the review board is complete.
If you would like to serve as a member of the review board, please contact (the conveners? Nassib? both?)
Add additional info about release contents and timeline? Or just put this in training?
- Difference between bugs and enhancements (e.g., "Submissions to FOLIO Analytics could represent enhancements - changes that simply add functionality to the repository - or bugs - errors in the repository files that either prevent queries from running or produce inaccurate results. Reviewers should prioritize reviews for bugs over enhancements.")
- Release timeline (e.g., "About two weeks before the planned FOLIO release date, the FOLIO Analytics repository will freeze any new submissions and transition to testing. During the testing phase, no new enhancements will be approved for inclusion in the release, but any bugs uncovered during testing should be addressed, submitted, and approved quickly. For reviewers, this means that the two weeks before the release date are times when a quick turnaround on reviews is required.")
Training topics (training still needs to be developed/scheduled)
- Identify a pull request that need a review
- Assign yourself to review a pull request
- Reviewing a pull request using the check list
- Communicating with a PR submitter
- Adding test data to the reference environment
- Differences between LDP and Metadb queries to look out for