Attendees (please add your name):
Magda Zacharska leeda.adkins@duke.edu (OLD ACCOUNT) Erin Nettifee Christine Tobias Amanda Ros Erin Weller gongd@msu.edu Jackie Magagnosc Monica Arnold Scott Perry Kimie Kester Sara Colglazier Robert Scheier
Note taker:
Meeting Recording:
- Recording and chat: https://recordings.openlibraryfoundation.org/folio/bulk-edit-working-group/2022-03-08T10:00/
Discussion:
Topic | Notes |
---|---|
Housekeeping
| Magda: Just some quick housekeeping. Please add your name to the list of attendees and to help Bob with notetaking, please state your name when you participate in the conversation. |
Development updates
|
Magda: (after Magda uploaded the edited match file, the response message now says the file has been uploaded to be more clear what is happening at this stage). This was also a change that was proposed to makes it a little bit more visible that we are just uploading the file here.
|
Proposed modification to the landing page |
You are getting additional option, which is download a March to records with CSV. And once all the changes are done, meaning you uploaded the modified file, the upload completed, and you are all the last form reporting. What is, uh, what records have been modified? You see the option of download records and CSV, and also download errors if applicable, if there are errors. Okay. So that option, if there are no errors, that option just won't appear in the menu. Exactly. It's not available. Okay. So this is how it is implemented right now. And I refer to this functionality CSV because we are using the, um, the CSV files. Uh, this is, uh, this, uh, it's sort of a repeat of the. Yeah, that makes sense to me. And that's the same, that's similar to how other apps treat sort of references to things. So what we are going to do in morning glory in morning, Gloria, we will have two sets of bulk edit permissions because we would like to separate those behaviors, um, into different streams. In morning glory, we will be implementing the, um, a UI driven or in app a bug edit. So whatever was delivered in lottos, will it be, uh, we'll have extension CSD and every new functionality will carry on us. A bulk edit permission, bulk edit view permission, and the permission. W w I'm not sure I understand that. So, and so we're going from first off, we're not releasing and Lotus, right. Um, when I'm still in a saying about the functionality we built so far, the pilot project or the pilot project. So yeah, so, so in morning glory, we would have six permissions that I don't understand why are we? Because, because the behavior will be different. Okay. I think for, well, first off it would help me if we didn't have permissions in the name, because we don't really do that in the, in the naming bunker. Did the edit bucket that you bucket it delete, this is what you would prefer. Well, so, um, It's I, I guess, I don't know, but I'm maybe it's the way this is going on the slide, but I'm finding myself really confused by having six permissions that look really similar and I'm not, and it's not clear to me why I would assign somebody full edit, edit CSB versus bulk, edit, edit all or whatever that ended up being called. I thought the reason was that the CSV was much more powerful in terms of what, what damage it can do except. So, uh, when we are done with morning glory, you will be able to, uh, edit some fields in inventory. You're using the. And you will be able to edit all user records using CSV approach by the end of morning glory. Most likely you will not have an option to edit all fields in. I tem. Right. So if the distinction is CSV versus in-app, then for the the three and a half ones, I think it would help to say that right. Bulk edit colon in app at full or, cause I assume it's also not clear to me. It's it's bulk edit, delete records. Is that what we're saying there? Like you can do it, you can, through the in-app workflow, you can delete records. So maybe even we can flip that. We can say bulk edit colon in app dash, edit records, full, get it. Colon in-app dash, you records. And then the, then the other ones you could, you could flip it and say bulk edits, CSV. And it records both at CS. I think that would be a clearer. Delineation of what we're actually trying to do. And I can, I can put that in the slack channel if that would, if that would help. But I think that's, that would make it clear to me what each of these does. Uh, someone wanted to say something just going to ask, so where it says an app, is that pertaining to a particular app, or once you turn on bulk edit in app, you can do it in any app. Uh, so with enough, this is what we need to build and we will start writing, build it for the item records. So when we turn up it enough, it will be only for inventory item records, but in app, um, let me, let me. As opposed to the extract transform load spreadsheet. I'm not confused about that. I'm confused about whether somebody automatically, if they get this permission can do it and users and an inventory. Right. We have not gotten to the point of trying to segment it beyond you have access to the app. Therefore you can, no. Once we add a second app, is that when we'll segment it, I just want to make sure that this is a very, very good. Thank you so much. I did not think about this. So you would like to, uh, separate like, um, bulk edit in up item items. So, uh, This is a good bond because you, it, someone may have a permission to edit records in inventory items, but not necessarily in, in acquisition. Right. So, uh, what should we do to make it Christina's had her hand up for a little bit. Go ahead, Christie. Oh, thanks. I think that my question's been answered because my question was, are we giving permission to edit permissions or permission to edit the records, but you have clarified that through your discussion that it's a bulk edit, edit records, view records, delete records, right? It's not actually granting, it's not, uh, permitting to. Okay. Got it. Thank you. Yeah. So, um, how do we handle this? Right. And I think that's a developer question too, because they need to be able to do that segment. Yes. But we can work on this. And for the end of morning glory, the in app will be all the items. So we can discuss this later. Once we start adding more application, more apps, but I really liked this point. Should do we should the naming company. Um, well up is being, uh, edit, uh, covered by the permission or not. And if I think it needs to, if we're going to expect the ability to set that. So how would you like to name it then? I was going to ask though, I mean, do, is there any examples where somebody would be allowed to do bulk edits, but would not be allowed to edit individual record? I would say the other way around. Yes, but no. So would it be possible instead of trying to define all the permissions in here that the permissions for bulk edit just gives you access to this app, but the actual permissions to do the bulk edits are still reliant on other permission settings. So for instance, I would have to have permissions to inventory and to be able to edit, to record. And bulk edit does nothing except allows me access to that app and relies on my permission sets elsewhere. Cause I'm afraid like if you right Thomas, you would still need UI permissions in the bulk edit app backend. You could maybe leverage the existing permissions, but you would still need to have something that says cause cause bulk edit book, edit, can't reference the UI permission for inventory to give you a UI permission to bulk. Right, but you can do the backend API permissions. It can pull in something from a mod. Um, if the permissions are stored in the token though, one country, couldn't, it just are. I'm thinking out loud here. If the permissions are stored in the token saying I have access to inventory through the UI and I have permissions to edit in there would walk out of can't access that permission set through Okai API, or is it just strictly passed on to my understanding is it has to do. With the way that the code references it, but that is an excellent developer question, because I think you have a good, you have a good idea about how to make this simpler and shorter, but I'm not, I'm not sure Sarah has her hand up. And this raises an interesting point because in, so I discovered in our current system, since I'm part of the five colleges and currently in our current system, we do like, um, without being granted the definite the specific permissions, I cannot edit a big record, an item record, or a holdings record currently, uh, by one of the other institutions. Right. Unless I have kind of like, if like, with like an acquisitions and folio we have now these acquisitions groups, they had to actually develop that for the pod colleges. Right. So again, going back to. So that we could assign each other, um, acquisition units. Yeah. Yes. And so this would, could come up for us, but going back to the, the question is, so I cannot, in my current system edit those records, but I can use batch services in our system to get around that if I need to. So I can actually actually, but anyways, but, but, but my point is in folio, I think, I think it was Thomas just now I forget who was speaking, sorry. Yeah. Was raising a really good point. Can it be that. It's not looking at what my permissions are elsewhere, about what records I can touch them when I can't touch. Would it, could it be that then suddenly with the bulk edit ability, I could potentially edit something that I wasn't supposed to admit. Right. Or like, you know, that it would contradict other permissions that were set up where it was limiting me, you know? Cause I'm, I'm just thinking about building this out, right? Like around users, right. We're all in folio together. Now what happens if I make some kind of query, there are UMass people in my query and then suddenly I edit them because I'm dealing with thousands of records. It's not like I'm looking at one by one by one. Right. But normally I wouldn't be able to edit that, that user. Yeah, I don't, I mean, I'm not in folio yet to no concrete examples, but I could think of running into problems like this in, um, if it's not referencing what my service point is or what my, my unit is, or my team, we, you know, for awhile there were going to be teams and things like this. I think we do need to have some kind of, especially as this gets built out, scaled up to include other apps. My concern, my understanding of the commission was in buckets. Uh, but this obviously can change that. Uh, once we grant you permission to the bulk edits, uh, you can, uh, you can. Do the bulk edit on the record. So it is overwriting, uh, your permissions, but, um, we did permissions that I had on my screen right now, um, that I wanted to discuss. There were another simplistic. Those are, those were the permissions that will the timing, what you will see in the action menu, depending on the permissions you have. So we are not even getting to the point where, um, we are not getting to the point. We are writing the changes to the database. We are discussing what the user can actually see in the UI to the, to the action menu. Doesn't make sense. Do I confuse you even more? No, that, that makes sense to me. We're just, these permissions are just going to be, if you can see the bulk edit app, as well as what options within the bulk add app, you can see, but not what actions will actually be successful in the bulk of it. So you'll get an error message. If you try to bulk edit, um, in an area, if a system you don't have permission. That's that you, that would be one of the error stating yes, we had, at some point to this, I could easily recreate it in the snapshots environment. Uh, this was, uh, something could be a user records that then when I was trying to update, I was getting care. There was not really very user-friendly you had to, um, scroll down right. To the, to the right, to see what was really the problem. But it was sexually stating that you cannot edit this record because it's so, so. Going back to, uh, to the permissions that I have right now that the drive, the UI behavior. And we definitely will come back to these, the conversation about, um, what should the permissions, um, the, to summarize what we said, first of all, you don't want the word permission. You would refer to her in op, uh, right in front of it. And I would leave the items for now out of it and leave it as an edit view and they'd eat red cards. And then when we start talking about the permissions on world records can be edited. We will come back to this. Would that make sense for you? Would you agree? Yeah, I would want to be consistent across the. Uh, so this would be CSV. This will be, is this acceptable? And the records that could come out, delete records. So, uh, we had five minutes. I would like to walk to the scenario where the in up, uh, up in up permissions are enabled. So on the landing page, the inventory items are selected. And at this point you can all do anything. Uh, action menu is still not visible until the preview is populated. No, we have a preview populated and the action menu has options. Download much records and you can still download them in CSV. You can download errors also in CSV and you can start bulk edit, but the behavior of the staff bug edit will be different. It will be in up, but this w we will come back to this later. Um, probably not today though, because of the time constraints, but a user is taken to in app, uh, edit, commits the changes. And this is the landing page. Again, after all the records have been successfully completed. And then what should the action menu, uh, contain here? Save change records and save errors. What else should be here? We currently in the CSV approach, we have a thinking CSV approach. Um, we, uh, we are, uh, having, uh, we are going to have a start bucketed, but this is because we can upload the file. And in app, we don't have the file to upload. We need to go to the, and we need to go to the, uh, to the, in up. Application that we can go only if we know what records we are going to be editing a stupid question and sorry, but, um, even with the in-app can I, uh, can I get the, can I save the record and downloaded prior to committing to yes. So if, if, if we go quickly to, uh, how it works. So this is, uh, we are providing item barcodes. You're uploading the file. So the behavior is until now the same as we already implemented. This is still the same behavior. Now you're clicking start. And this is the first change. So you, you have this places where you specify what changes you want to do. This is the in-app part. And then, oops. So this is what I want it to be. So this is the moment before you will be, want me to make it larger. Can you see it a little bit larger or you can just read yet. Oh, super. So what is happening right here before you commit your changes? You are in the, in there you are sure. Are you sure? Which states how many records you will be changing. This is again review, but you have this option, download preview. You can download the files and see them. Those are, you will see how the records will be updated once you commit the changes. Uh, yes, that's great. That's really super. Um, I still like the, what you were asking before that to have the option afterwards to download my errors. And so when you get to this screen, so you update it, you make the changes. So right now you can upload, download the list of the records that were modified and also the errors. Okay. And I apologize. I need to run to another meeting so I can stay much longer. Thank you very much. This was again, another very good discussion and we didn't cover all the elements, but we have something to look forward for our next meeting. Thank you very much. Thank you. Bye bye. |
Action menu - support for in app and CSV approach | |
Future discussion topic (time permitting):
| |
Chat and Notes: https://ux.folio.org/storybook/?path=/story/buttongroup--basic-usage I checked with a developer, John Coburn , Stripes-Component-Lead for FOLIO, and he said the button at the top of the left-hand pane, in our case, Identifier and Query, is called a ButtonGroup.I said a Segmented Button because I have heard other Devs and UI people call it that but officially they call it a ButtonGroup: |