Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

...

...

...

Requirements - 
Jira Legacy
serverSystem

...

JIRA
serverId01505d01-b853-3c2e-90f1-ee9b165564fc
keyMODORDSTOR-37

Spike to determine whether the "first" and "last" fields in the collection schemas should be 0 or 1 based. Do we even need these fields? It doesn't look like other modules have them.

See https://github.com/folio-org/acq-models/pull/61#discussion_r244816230 for details

...

  • "first" and "last" fields are not being used in UI orders
  • All APIs are setting "first" and "last" field in collection in mod-orders-storage but those are never being used further.
  • In daily standup, this was brought up and consensus was these fields were created when storage module was first defined but these fields were never used in production. 

POC

Remove  "first" and "last" field from example https://github.com/folio-org/acq-models/blob/master/mod-orders-storage/examples/adjustment_collection.sample

Remove  "first" and "last" field from schema https://github.com/folio-org/acq-models/blob/master/mod-orders-storage/schemas/adjustment_collection.json

...

Remove "first" and "last" fields from:

  • All collection schemas in mod-order-storage
  • All collection level examples in mod-order-storage
  • All collection level API's in mod-orders-storage

...