Make searching work

Description

I only just realised typing into the search box is a no-op.

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Mike Taylor November 28, 2017 at 1:50 PM

I released ui-users v2.12.0. That means that the most recent released ui-users depends on a release of stripes-smart-components that gives it what it needs (the query URL parameter). And of course the git-master version of ui-users is similarly OK with git-master of stripes-sample-components.

I _think_that means I can now go ahead and remove from <SearchAndSort> the code that generates the redundant search parameter, which nothing now uses. Because the only ui-users code that anyone should be running against git-master stripes-smart-components would be ui-users git-master.

Mike Taylor November 28, 2017 at 12:58 PM

Having done the first three of the four issues in the comment before last, I am minded to go ahead and release the modified ui-users so I can then do . Maybe after lunch.

Mike Taylor November 28, 2017 at 11:40 AM

Fixed by the change in .

Mike Taylor November 28, 2017 at 11:06 AM
Edited

I am going with the second solution. The sequence of issues is as follows (edited to insert , which was not in the original list):

  • – Have <SearchAndSort> set both query and search URL parameters

  • – Release stripes-smart-components v1.3.0

  • – Use the URL parameter query instead of search

  • – Release ui-users v1.12.0

  • – Remove search URL parameter from <SearchAndSort>

Mike Taylor November 28, 2017 at 10:54 AM

On the other hand, I really don't want to make myself responsible for a stripes-components release – it's accumulated a ton of issues since the last release, and it's really for to handle that process. So here's an alternative:

1. Modify <SearchAndSort> so it sets both query (as expected by makeQueryFunction) and search (as expected by the un-DRYed modification in ui-users).
2. Release stripes-smart-components (a much more lightweight process than stripes-components).
3. Modify ui-users to use query instead of search
4. (After some time) remove generation of the search parameter from <SearchAndSort>

This is uglier in that it gives us UI URL with duplicate parameters for a while; but it'll be quicker to get through, because I won't be dependent on a giant stripes-components release that AFAIK is not scheduled.

Done

Details

Assignee

Reporter

Labels

Priority

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created November 27, 2017 at 4:47 PM
Updated November 29, 2017 at 4:05 PM
Resolved November 28, 2017 at 11:40 AM
TestRail: Cases
TestRail: Runs