Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Fulfillment Preference field not respecting user fulfillment preferences in edit mode

Description

Overview:

When creating a new request, the contents of the "Fulfillment preference" field menu are determined by the user's fulfillment preferences. Eg. if the user is not allowed to place delivery requests, then the "Deliver" menu option is excluded. This is not the case in the edit screen.

Steps to Reproduce:

  1. Log into Kiwi Bugfest (or any other current FOLIO environment)

  2. Find a request with a request status of "Open - Not yet filled"

  3. Locate a request from a user who is not allowed to place delivery requests ("Delivery" check box is unchecked in  the "Request preferences" section of the "Extended information" accordion in Users)

  4. Select "Edit" from the request detail action menu

  5. Attempt to edit the "Fulfillment preference" field by clicking on the menu.

Expected Results:

Only one menu option is presented: "Hold shelf"

Actual Results:

Two options are presented: "Delivery" and "Hold shelf"

Additional Information:

The Delivery address field does not populate because there are no delivery addresses available for the user.

URL:
Interested parties:

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

1
  • 28 Jan 2022, 07:30 AM

Checklist

hide

TestRail: Results

Activity

Show:

Brooks Travis January 28, 2022 at 3:35 PM

Verified in snapshot.

Stanislau Snapok January 28, 2022 at 7:20 AM
Edited

Hello !

Tested on snapshot env, works as expected.
Evidence added.

cc:

Stephanie Buck January 27, 2022 at 2:12 PM

I don't know how the check got there either, ,  and , but we want the behavior to be the same when editing as when creating. 

Brooks Travis January 26, 2022 at 11:35 PM

I do not.

Zak Burke January 26, 2022 at 8:54 PM

, the function that determines which fulfillment options to show specifically checks whether we are creating a new request or editing an existing one. The PR simply removes that check. That's fine, but it bugs me that we don't know why that check was there in the first place. Do you have any idea? The ticket reference when we originally made the change is https://folio-org.atlassian.net/browse/UIREQ-312#icft=UIREQ-312, but that only references request-creation not editing.

Done

Details

Assignee

Reporter

Tester Assignee

Labels

Priority

Story Points

Sprint

Development Team

Vega

Parent

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created October 20, 2021 at 5:58 PM
Updated March 7, 2022 at 1:21 PM
Resolved January 28, 2022 at 3:35 PM
TestRail: Cases
TestRail: Runs

Flag notifications