Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

When the hold shelf clearance report API query has not yet finished, the UI reports an inaccurate message about the user not being logged into a service point

Description

Overview:

If the API query to the hold shelf clearance report endpoint is slow to resolve and the user attempts to export the hold shelf clearance report via the action menu in the request search results pane, they are presented with a modal telling them they are not logged into a service point (see attached screenshot).

Steps to Reproduce:

  1. Log into Juniper BugFest environment as a user with D Angelo Law Library (possibly any service point) selected as their current service point

  2. Click the action menu in the request search results pane

  3. Select "Export hold shelf clearance report for <service point name>

Expected Results:

Clearance report downloads.

Actual Results:

IF the underlying API call to the report API has not completed, then the user receives an error modal indicating that they are (inaccurately) not logged in to a service point. Otherwise, the file downloads as expected.

Additional Information:
URL:
Interested parties:

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

1
  • 22 Jul 2021, 12:53 PM

Checklist

hide

TestRail: Results

Activity

Show:

Brooks TravisAugust 5, 2021 at 3:24 PM

Verified in Bugfest.

Brooks TravisAugust 4, 2021 at 3:11 PM

I don't think I can really verify this in snapshot, unless we can get a bunch of expired hold shelf requests into the system. I'm good with that change, if we want just go ahead and take it to Bugfest.

Michal KuklisAugust 2, 2021 at 8:14 PM
Edited

 I added a check which will disable the export report button until the query to: 

circulation/requests-reports/hold-shelf-clearance/SERVICE_POINT_ID

is finished. This will work similarly to "Print pick slips" button.

I agree with you that the real fix would be to figure out why the get request to circulation/requests-reports/hold-shelf-clearance/SERVICE_POINT_ID is taking so long. This will have to be done on the server. Perhaps filing a new Jira under mod-circulation would be a good idea?

Brooks TravisJuly 27, 2021 at 7:50 PM

Any update on this?

Brooks TravisJuly 23, 2021 at 2:16 PM

 Not sure if we want to try and escalate this to PTF, or not. The slow response from the API seems consistent across service points in Bugfest. We need a UI-level fix for the erroneous modal alert, but I'm also concerned about the overall performance that is putting things into that error state to begin with.

Done

Details

Assignee

Reporter

Labels

Priority

Story Points

Sprint

Development Team

Prokopovych

Fix versions

Release

R2 2021 Bugfix

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created July 22, 2021 at 12:52 PM
Updated October 6, 2021 at 1:51 AM
Resolved August 4, 2021 at 3:56 PM
TestRail: Cases
TestRail: Runs

Flag notifications