Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Error reordering queue when I don't have Requests: Reorder queue option

Description

Background: We have changed the Move request workflow so that when you are finished moving a request, the reorder queue page is opened. The challenge is that the original permission for "Requests: Move to new item" doesn't provide the ability to reorder the queue. I think we should provide that ability along with the Requests: Move to new item permission

I am writing this up like a bug because it's easiest, but classifying as a story because this is a requirements change.

Steps to repro:

  1. In folio-snapshot, as diku_admin, create a new user with only "Requests: Move to new item, reorder queue" and one of the following other permissions: "Requests: View", "Requests: View, create" or "Requests: View, edit, cancel" Do NOT give Requests: Reorder queue

  2. Set up a requests on an item in an instance that has more items (so you can move it)

  3. Put another request on another item in the instance

  4. Log out and log in as your new user

  5. Go to requests and open the pane header dropdown

  6. Notice that you have Move requests option and also Reorder queue (this is correct)

  7. Move your request to another item (choose one that has at least one other request on it)

  8. When the move is complete, you are left on the reorder queue page (this is correct)

  9. Now attempt to reorder the queue

Expected:

  • Should be able to reorder the queue without error.

  • Rename permission "Requests: Move to new item, reorder queue" CB: Added on 2019-12-09

  • This permission should also give access to the Reorder queue option in the pane header dropdown. CB: Added on 2019-12-09 CB: Will have incorrect name "Requests: Move and reorder to new item" in the Q4 release but name will be fixed with the Q1 2020 release

Actual: Get an error

Environment

None

Potential Workaround

None

Attachments

4
  • 06 Jan 2020, 08:54 AM
  • 03 Jan 2020, 12:26 PM
  • 11 Dec 2019, 01:14 PM
  • 29 Nov 2019, 09:48 AM

Checklist

hide

TestRail: Results

Activity

Show:

Cate Boerema January 6, 2020 at 11:35 AM

Thanks ! I think we can wait on the permission name change. Thanks for looking into this. Glad you don't need to roll a new release

Zak Burke January 6, 2020 at 10:59 AM

, this fix has been in place since v1.14.0, albeit with some incorrect wording in the permission ("Requests: Move and reorder to new item" instead of "Requests: Move and reorder to new item"). Here's the relevant history:

  • 2019-12-04: permission values are corrected (effectively fixing the issue)

  • 2019-12-06: release v1.14.0

  • 2019-12-11: permission name is changed (cosmetic change only)

  • 2020-01-02: Zak lists tickets to be included in patch releases of UI modules

  • 2020-01-03, 12:03: Cate adds the q4-2019-bugfix tag

  • 2020-01-03, 23:46: release v1.14.1

I could publish a v1.14.2 release with the corrected permission name (a cosmetic change only, no change to permission values) with relatively little effort. LMK.

Marc Johnson January 6, 2020 at 10:19 AM

I don't think moving a request should require checking a loan policy.

I didn't think so either, something must have changed to mean it is being loaded anyway. I don't know why.

I wonder if test automation could catch some of these permission issues as soon as they arise?

That is a good topic for us to discuss. It is challenging to automate within the backend module itself, maybe other tests can help identify it later in the process.

Cate Boerema January 6, 2020 at 8:54 AM

this seems to be working great now. Closing

this was fixed a while ago but testing was blocked by https://folio-org.atlassian.net/browse/CIRC-610#icft=CIRC-610 until now. Question: do you think the changes associated with this issue would have been included in this release: https://github.com/folio-org/ui-requests/releases/tag/v1.14.1? Or do we need to cut another bugfix release for it?

I don't think moving a request should require checking a loan policy. I wonder if test automation could catch some of these permission issues as soon as they arise? I added an item to the release retro board for this: https://funretro.io/publicboard/uhS7lurEs9WACO0ZcntIKkeLqUq1/c5bd9c2d-df0b-45f8-aa24-c9a520618b91

Cate Boerema January 6, 2020 at 8:54 AM

this seems to be working great now. Closing

this was fixed a while ago but testing was blocked by https://folio-org.atlassian.net/browse/CIRC-610#icft=CIRC-610 until now. Question: do you think the changes associated with this issue would have been included in this release: https://github.com/folio-org/ui-requests/releases/tag/v1.14.1? Or do we need to cut another bugfix release for it?

I don't think moving a request should require checking a loan policy. I wonder if test automation could catch some of these permission issues as soon as they arise? I added an item to the release retro board for this: https://funretro.io/publicboard/uhS7lurEs9WACO0ZcntIKkeLqUq1/c5bd9c2d-df0b-45f8-aa24-c9a520618b91

Done

Details

Assignee

Reporter

Tester Assignee

Labels

Priority

Story Points

Sprint

Development Team

Prokopovych

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created November 29, 2019 at 9:50 AM
Updated April 2, 2020 at 12:28 PM
Resolved January 6, 2020 at 8:54 AM
TestRail: Cases
TestRail: Runs