Wrong delivery address selected when preference = hold shelf and then changed

Description

Steps to repro:

  1. Log into folio-snapshot

  2. Go to Users and edit a user and, under Request preferences, set them up with

    1. Delivery and Hold shelf both checked

    2. Select a Default pickup service point

    3. Make fulfillment preference Hold shelf

    4. Create two addresses and select one as the Default delivery address one of them (I had Home and Order and Order was the Default)

  3. Save user and go to Inventory

  4. Find an item record and create a request for that item

  5. Select your user as the requester

  6. Change the Fulfillment preference to delivery

  7. Note the delivery address is Home, instead of Order (BUG #1)

  8. Note the Home address doesn't display below the menu (BUG #2)

  9. Now try to save the record

  10. Note the validation "Please select an item" that displays below the menu (BUG #3) CB: This still happens if you save the record and the edit it and run through these steps.

Expected: The Delivery address should be "Order" when you choose Fulfillment preference = Delivery since that's the selected default on the user record. The Order address should display below the menu. No validation should display saying you need to select something when something is already selected.

Actual: See repro steps

Screencast attached

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

3

Checklist

hide

TestRail: Results

Activity

Show:

Cate Boerema January 6, 2020 at 2:14 PM

Cate Boerema December 18, 2019 at 1:10 PM

You're right, . I can't repro today in snapshot. I am closing this bug. Thank you so much for getting this fixed in time!

Владислав Велицкий December 18, 2019 at 8:55 AM

Hi , try to recheck it, on snapshot I can't to reproduce it. Yesterday I fix this error as part of UIREQ-385 (your last comment here was about the same problem), maybe you tested it before the recent updates hit on snapshot.
Actually we can close this bug so that it gets into the Q4 release.

Now I see just one little bug, when we edit request where Fullfillment preference = Hold Shelf, the form does not set an already selected value for Pickup service point. I found a way how to fix it, but I think it is out of scope of this task so a new ticket can be created for this. Thanks!

Cate Boerema December 17, 2019 at 8:23 PM
Edited

Hi , this is working sooo much better. The only problem is that I did the following:

  1. Ran through the above repro steps - everything worked much better

  2. Then I edited the request and switched from Delivery to Hold shelf

  3. Then I selected a pickup service point other than the default

Expected: No error

Actual: Error

Do you think I should file a different bug for this problem? I would kind of like to get this bug closed so it can be put into Q4. Despite the remaining issue, I think it's an improvement over what is in the Q4 release now. Let me know what you think. Thanks!

Cate Boerema December 11, 2019 at 12:37 PM

Hi this is looking a bit better, but there are still some issues with how this all works. I'm guessing it might be a struggle to get this fully fixed prior to the bug fix deadline (December 18). If so, we should think about whether it makes sense to apply the changes you have as a bug fix (since it is a slight improvement) or just wait until Q1 and fix it completely. I guess waiting until Q1 would be okay, if you can't get this done.

Reopening and assigning back to you. See attached screencast for remaining issues.

Done

Details

Assignee

Reporter

Tester Assignee

Priority

Story Points

Sprint

Development Team

Spitfire

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created November 20, 2019 at 10:22 AM
Updated January 27, 2020 at 11:25 AM
Resolved December 18, 2019 at 1:10 PM
TestRail: Cases
TestRail: Runs