Update request whitelist to handle new "Awaiting delivery" status

Description

Purpose: To specify which types of requests are allowed or disallowed when item status = Awaiting delivery

Scenarios:

  1. Scenario

    • Given item status is "Awaiting delivery"

    • When a request is created for that item

    • Then the Request type menu should include only those request types allowed per the Request whitelist, namely: Hold and Recall

NOTE: I believe we still have to maintain the whitelist in two places (frontend and backend). Corresponding backend story is: CIRC-511

Environment

None

Potential Workaround

None

Attachments

1
  • 20 Nov 2019, 01:22 PM

Checklist

hide

TestRail: Results

Activity

Show:

Cate Boerema November 28, 2019 at 8:12 AM

Works great. Thank you!

Cate Boerema November 21, 2019 at 12:12 PM

Makes sense. Thanks !

maksym_dryha November 21, 2019 at 11:54 AM

, you see the bug because the story is not done yet, so we don't need a separate ticket

Cate Boerema November 20, 2019 at 1:21 PM

I know work on this hasn't started, but I just wanted to leave a comment here because I ran into some bug behavior that may result from the fact that this work hasn't been completed. I wanted to give the developer a heads up and also leave a reminder for myself to retest this scenario when this is ready to test.

Please let me know if you don't think this bug is related to this story and I will file it separately.

Steps to repro:

  1. In folio-snapshot, create a request with fulfillment = delivery

  2. Check that item in so the Item status = Awaiting delivery

  3. From the request pane header dropdown, select Duplicate

  4. From the Request form, change the requester

  5. Attempt to save the new request

Expected: Should allow save because all the circ rules are using the "Allow all" request policy

Actual: Get the "Can't make requests for this patron/item combination" message which usually only displays when a request creation is prevented by circ rule/request policy

Additional info:

  • I noticed that the Request type menu is not displaying in the UI when duplicating in this case. Usually, when you duplicate a request, the Request type menu displays and only includes whichever options are available per the whitelist. The fact that it's not currently displaying is probably why I'm seeing this error.

  • I was able to duplicate delivery requests when they were Open - Not yet filled. It seems this is just a problem when they are Open - Awaiting delivery

  • This problem occurs regardless of the request type (I saw it when duplicating both a page and a hold). They key factor seems to be the item or request status of Awaiting delivery

Attaching a screenshot

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Spitfire

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created October 14, 2019 at 3:27 PM
Updated January 27, 2020 at 11:24 AM
Resolved November 28, 2019 at 8:12 AM
TestRail: Cases
TestRail: Runs

Flag notifications