"Can't move above page" message showing when it shouldn't
Description
Steps:
Log into folio-snapshot
Go to Inventory and pick an instance with more than one available items (I used Temeraire)
Create a request on copy 1 (it will be a page)
Check out copy 2
Create a request on copy 2
Create another request on copy 1
Move request from copy 2 to copy 1
Expected: Should move into position 2 of the queue because requests are slotted in according to creation date and this request was created second. No popup should display with the move.
Actual: "Requests cannot be moved above page requests, even when fulfillment has not begun. This request will be moved to position 2 in the request queue." popup displays when it shouldn't , as this move wouldn't displace the page at the top of the queue.
Additional info: Click confirm and the move is made to position 2 which is where it should have gone anyway because of the request creation date.
Hi @Matt Connolly I can't test this because I can't create a request in folio-snapshot or folio-testing (see https://folio-org.atlassian.net/browse/UIREQ-335#icft=UIREQ-335). Do you think that could be related to this fix? I was definitely able to create requests on Friday and this is the only request-related fix that was merged since then. This is a very high priority to fix.
Cate Boerema September 6, 2019 at 9:29 AM
Is it safe to assume that if an item has a page request, it will always be the first request in the queue?
Yes
If so, then we would want to show the popup only if the first request in the destination queue is a page request AND the creation date of that request is later than the creation date of the request being moved. Does that sound right?
This sounds exactly right.
Thanks!
Matt Connolly September 4, 2019 at 2:17 PM
That makes sense. Is it safe to assume that if an item has a page request, it will always be the first request in the queue? If so, then we would want to show the popup only if the first request in the destination queue is a page request AND the creation date of that request is later than the creation date of the request being moved. Does that sound right?
Steps:
Log into folio-snapshot
Go to Inventory and pick an instance with more than one available items (I used Temeraire)
Create a request on copy 1 (it will be a page)
Check out copy 2
Create a request on copy 2
Create another request on copy 1
Move request from copy 2 to copy 1
Expected: Should move into position 2 of the queue because requests are slotted in according to creation date and this request was created second. No popup should display with the move.
Actual: "Requests cannot be moved above page requests, even when fulfillment has not begun. This request will be moved to position 2 in the request queue." popup displays when it shouldn't , as this move wouldn't displace the page at the top of the queue.
Additional info: Click confirm and the move is made to position 2 which is where it should have gone anyway because of the request creation date.