Subheader should read "Other items in <ResourceTitlefromInstance>"
Also, from https://folio-org.atlassian.net/browse/UIREQ-269#icft=UIREQ-269, there should be no close button. To select an item, you just select the row and that's it (similar to how you select users in the user search and select popup). If you want to close the popup without making a selection, you should use the X in the upper left. The current "Close" button is confusing and almost looks like it's where you confirm your selection.
CSP Request Details
None
CSP Rejection Details
None
Potential Workaround
None
Attachments
2
10 Jun 2020, 08:27 AM
01 Aug 2019, 09:10 PM
Checklist
hide
TestRail: Results
Activity
Show:
Cate Boerema June 15, 2020 at 7:46 AM
Looks great! Thanks @Kyle Felker. Thanks also to @Zak Burke for fixing the translation.
Zak Burke June 13, 2020 at 12:21 PM
Ugh; looks like FOLIO-2630 is preventing translation changes from propagating to the en_* locales which is why this fix hasn't appeared in snapshot. I just opened a second PR in ui-requests to propagate those changes manually.
Kyle Felker June 10, 2020 at 12:50 PM
Part of the fix involves a change to the translation file. That change should be propagated out from the master file to the other translation files, but currently there's a bug in Lokalise that is preventing English language translation files from being updated: https://folio-org.atlassian.net/browse/FOLIO-2630. Until that bug is fixed, the solution won't show. Should I set this bug as being blocked by that issue?
Cate Boerema June 10, 2020 at 8:27 AM
Hi @Kyle Felker I don't see this change yet in snapshot. Should I?
Kyle Felker June 8, 2020 at 2:39 PM
the button on this modal seems to have been removed already. I'll work on fixing the label.
According to Scenario 2 of https://folio-org.atlassian.net/browse/UIREQ-269#icft=UIREQ-269 the pop-up Subheader 1 should contain the title of the instance but it doesn't:
Expected:
Subheader should read "Other items in <ResourceTitlefromInstance>"
Also, from https://folio-org.atlassian.net/browse/UIREQ-269#icft=UIREQ-269, there should be no close button. To select an item, you just select the row and that's it (similar to how you select users in the user search and select popup). If you want to close the popup without making a selection, you should use the X in the upper left. The current "Close" button is confusing and almost looks like it's where you confirm your selection.