Create/Derive/Edit a MARC Bib/Holdings/Authority record - display inline validation error messages for current UI validation
Description
Environment
Potential Workaround
Attachments
- 26 Jul 2024, 11:33 AM
- 26 Jul 2024, 11:33 AM
- 26 Jul 2024, 11:33 AM
- 26 Jul 2024, 11:33 AM
- 22 Jul 2024, 09:50 AM
- 19 Jul 2024, 02:46 PM
- 19 Jul 2024, 02:46 PM
- 19 Jul 2024, 02:46 PM
- 19 Jul 2024, 02:46 PM
- 19 Jul 2024, 02:46 PM
- 19 Jul 2024, 02:46 PM
- 19 Jul 2024, 02:46 PM
has to be done before
is required by
relates to
Checklist
hideActivity
Valery_Pilko July 26, 2024 at 11:33 AM
Re-tested on Snapshot environment:
Issue 1 - Still reproduces, @Khalilah Gambrell will create a separate story.
Issue 2 - Fixed, see attached screenshot:
Issue 3 - Fixed. For MARC bibs when there is an invalid value in the LDR of MARC bib record and user clicks on the “Save & close” focus moves to the editable box “ELvl” (see attached screenshot). Probably will be handled on the created story for issue 1.
Issue 4 , 5, 6, 7 - will be handled in the scope of https://folio-org.atlassian.net/browse/UIQM-631
Issue 8 - Fixed, see attached screenshot:
Issue 9 - Fixed.
Issue 10 - Fixed, see attached screenshot:
Issue 11 - Still reproduces, @Khalilah Gambrell will create a separate story.
Ready for PO review.
Valery_Pilko July 24, 2024 at 12:46 PM
Hi @Denys Bohdan - we discussed issues with @Khalilah Gambrell
You can fix the issues 2, 3, 8, 9, 10 in scope of this story.
For other cases (1 and 11) we will create additional stories.
We will not do anything with 4
5, 6, 7 will be handled in the scope of UIQM-631
Denys Bohdan July 22, 2024 at 10:16 AM
@Valery_Pilko I think it’s also out of scope of this ticket, it’s not worth to spend effort to change all messages on UI since soon we’ll be receiving them from back-end.
Valery_Pilko July 22, 2024 at 9:50 AM
Hey @Denys Bohdan - I’ve found one more case which should be discussed:
Question 11 - Inline error messages have several MARC tags specified in each message when controlled subfields are added manually to several linked fields
Should we separate messages in this case?
Denys Bohdan July 22, 2024 at 9:02 AM
Hey @Valery_Pilko and @Khalilah Gambrell I’ve reviewed all the questions/issues:
This is a conversion issue from object to string. when Elvl or other fields is removed and we convert to string - the string becomes 1 character shorter, hence the error. but that also means that non-editable fields shift and are considered edited. but we didn't show it before because we showed only one error.
I think this needs to be fixed in a separate ticket because it wasn’t introduced in this one.will fix
works for other fields. will fix for fields with disabled tag inputs
works the same as on Q bugfest. If additional validation is needed it should be added to back-end requirements
works the same as on Q bugfest. If additional validation is needed it should be added to back-end requirements
works the same as on Q bugfest.
works the same as on Q bugfest. (dehaviour is different if editing/ading a field)
will fix
will fix
will fix
So, issues 3, 4, 5, 6, 7 - I think we shouldn’t fix anything in scope of this ticket because the behaviour for them didn’t change and this story only covers changing toast notifications to inline messages + moving focus to first failed field.
Details
Assignee
Denys BohdanDenys BohdanReporter
Denys BohdanDenys BohdanPriority
P3Story Points
3Sprint
NoneDevelopment Team
SpitfireFix versions
Release
Ramsons (R2 2024)TestRail: Cases
Open TestRail: CasesTestRail: Runs
Open TestRail: Runs
Details
Details
Assignee
Reporter
Priority
P3
For MARC21 validation support validation error messages should be displayed inline for each field, instead of current pattern with toast notifications.
To kick off UI work related to MARC validation without waiting for BE implementation to be completed, we can implement inline error messaging for current validation approach, which could then be integrated with new BE validation.
Assumption: even though MARC Holdings validation approach will stay the same after UIQM-631: Create/Edit/Derive a MARC bib/authority/holdings record > Display MARC record validation errors inlineClosed (meaning MARC Holdings records will be validated on UI) - we will show validation error messages inline, however there will be no warn messages, or help icons.
Requirement 1: Hit any Save button (or use the Save shortcut key) Then run MARC validation rules
IF there are no MARC validation rules errors THEN proceed with saving record. Same as current behavior and workflow.
IF there is a MARC validation rule error(s) THEN display error(s) inline AND shift focus to first field with error.
IF there are validation errors and the user doesn’t fix any of them THEN they can click any Save button again AND will continue to see the same error messages
Requirement 2: Display MARC rule validation error inline
See mockup 2 https://drive.google.com/file/d/17Bwn7dde6M656kV__7_dVNTzCJDiDiIG/view?usp=sharing (DO NOT implement the inline error messages as shown on the mockup. Please implement the messages that are noted in this requirement.)
Inline error message format: Show error icon (red exclamation mark) <<Error type Fail/Warn>> : Error message
Per field, multiple error messages may display inline
DO NOT show Field Help icon (for Bibs and Authorities this information will come from BE validation and will not be available for Holdings)
Show Field Help icon is a separate requirement for MARC Bib and MARC Authority records, as we may implement later based on release scope https://folio-org.atlassian.net/browse/UIQM-656
IF a field does not display and it is required then display as a toast notification: Show error icon (red exclamation mark) Fail : Record cannot be saved without field <<field number>>.
Requirement 3: No change to authority linking messaging display (including messaging to handle race conditions)
Requirement 4: No change to validation rules