[Query Builder] Refactor valueSourceApi + source handling in the same field
Description
Currently, fields with valueSourceApi must have a redundant, self-referencing source defintion for compatibility with previous FQM/query builder code. This should be refactored to eliminate the redundant source property.
From Teams chat:
It's kind of messy, but I believe the query builder only hits the GET columnValues API if it sees that the field has a "source". So the source is necessary to get it to hit the API for the values, where it then uses the valueSourceApi. But really I think we should probably get the query builder to send that request if it sees either source OR valueSourceApi in the field definition. Then fields like this shouldn't need the source anymore
Something to consider with this one: We’ve started using the source property for more general configuration of this behavior, so it may be better to move valueSourceApi into source and make the QB not worry about valueSourceApi at all
Currently, fields with
valueSourceApimust have a redundant, self-referencingsourcedefintion for compatibility with previous FQM/query builder code. This should be refactored to eliminate the redundantsourceproperty.From Teams chat: