ui-plugin-eusage-reports: Do not use dependencies of stripes-acq-components

Description

Do not use dependencies of stripes-acq-components
In the file MatchEditor.test.js is the import of mockOffsetSize

 

Concerning mocks, see “mocks should remain local“:
https://github.com/folio-org/stripes-testing/pull/115

Environment

None

Potential Workaround

None

Checklist

hide

Activity

Show:

Mike TaylorJuly 31, 2024 at 2:48 PM

Perfect, thank you for indulging my pedantic interest.

Viola E.July 31, 2024 at 2:29 PM

I am glad that you share the same opinion.
Yes, k-int and stripes-erm-components do not appear here, I am going to adjust the title and description of the ticket.

Mike TaylorJuly 31, 2024 at 2:14 PM

I see, thank you. That makes sense. It’s a dev-dep because it’s only used for running tests. So I think k-int and stripes-erm-components are red herrings here?

BTW., IIRC stripesCore.mock and the rest are now provided by another Stripes library, but I don’t remember offhand what it’s called. I bet knows.

Viola E.July 31, 2024 at 1:15 PM

This ticket is just to resolve this "@folio/stripes-acq-components": "~5.1.0" dependency:
https://github.com/folio-org/ui-plugin-eusage-reports/blob/ad52738bd36b23544610c8da785c921598621923/package.json#L70

In the file MatchEditor.test.js is the import of mockOffsetSize

Mike TaylorJuly 31, 2024 at 1:11 PM

I don’t see the listed dependencies in the ui-plugin-eusage-reports package file — https://github.com/folio-org/ui-plugin-eusage-reports/blob/ad52738bd36b23544610c8da785c921598621923/package.json#L83-L89 — what am I missing?

Done

Details

Assignee

Reporter

Tester Assignee

Priority

Sprint

Development Team

Leipzig

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created July 30, 2024 at 8:21 AM
Updated September 17, 2024 at 7:31 AM
Resolved September 16, 2024 at 7:27 AM
TestRail: Cases
TestRail: Runs

Flag notifications