Add permission-guards for organization settings pages

Description

See STRIPES-469 for details.

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Mike Taylor September 1, 2017 at 10:18 PM

Added necessary subpermissions to setting-page permissions. https://github.com/folio-org/ui-organization/commit/c4c51e8038e2323c58ff63e5c37c2e300a53fba7

(That comment says it's part of UICIRC-10, which is obviously nonsense, but it's too late to change it now.)

Mike Taylor August 31, 2017 at 11:58 PM

Thanks, Wayne! You've been a trooper on this.

Wayne Schneider August 31, 2017 at 11:56 PM

Permissions added to folio-ansible (https://github.com/folio-org/folio-ansible/commit/bfb5a8e57545adff9e7728aa5ca82ccde15cbf8d), will be included in next build.

Mike Taylor August 31, 2017 at 11:47 PM

On Slack, suggested:

what if mod-configuration can only be touched from an Okapi module, and Stripes need to communicate with that module directly. Like if mod-users need to store a configuration then it exposes a /users/configuration/foo endpoint, enforce business rules, and store it in mod-configuration.

This is a very interesting idea at all. It's a bit like Wayne's notion of shim modules, but much more lightweight. One could even imagine RMB facilities that make specifying these API endpoints and their associated permissions a matter of a single line of configuration.

Mike Taylor August 31, 2017 at 11:25 PM

Well, I went ahead and created permissions for the four settings pages, so we can use them if we want them and need not if we don't want to. , would you please add the following permissions to diku_admin? ui-organization.settings.key-bindings, ui-organization.settings.locale, ui-organization.settings.plugins, ui-organization.settings.sso.

Done

Details

Assignee

Reporter

Labels

Priority

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created August 31, 2017 at 1:43 PM
Updated September 1, 2017 at 10:19 PM
Resolved September 1, 2017 at 10:19 PM
TestRail: Cases
TestRail: Runs