There should not be separate "bin" and "scripts" directories

Description

I created bin to hold the folio-port-ldp-queries.mjs script (see ). Then, forgetting that I already had this, I created scripts to hold add-tq-repo.js. Having both of these areas is confusing — made worse by the fact that one of them has its own package.json for its @indexdata/foliojs dependency but the other does not.

The bin directory is externally known — mentioned in the change-log, in a Jira issue and in release notes — so it should persist, and scripts should merged into it.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Charlotte Whitt November 7, 2023 at 7:49 AM

Okay. I'll close the ticket as done. Np.

Mike Taylor November 6, 2023 at 7:29 PM

Trying to verify this seems nonsensical to me. It's a change that means nothing to anyone but the developer.

Charlotte Whitt November 6, 2023 at 6:09 PM

So - normally all UI tickets needs to be verified, manual tested in FOLIO Snapshot. Sometimes you need to verify the change by looking in the developer tool. Does that make sense?

How exactly to verify I have not looked in to (yet) - but can do that, if I'm to pick up this test.

Mike Taylor November 6, 2023 at 5:09 PM

I don't understand what wants to do by way of manual testing. Look at https://github.com/folio-org/ui-ldp and note that there is no longer a scripts directory at the top level?

Charlotte Whitt November 2, 2023 at 1:19 PM

Hi - please do the manual testing of this ticket, and then we can close it.

Done

Details

Assignee

Reporter

Tester Assignee

Labels

Priority

Sprint

Development Team

Thor

Fix versions

RCA Group

TBD

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created October 31, 2023 at 12:45 PM
Updated November 7, 2023 at 7:49 AM
Resolved November 7, 2023 at 7:49 AM
TestRail: Cases
TestRail: Runs