No way to indicate that a report parameter is disabled

Description

Because the metadata files for reports are written in JSON, there is no mechanism for comments, and so no way to "comment out" a parameter definition that is not needed. There should be a boolean disabled property within each parameter definition which tells the UI, when true, not to display the field.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Mike Taylor November 13, 2023 at 5:30 PM

Thanks, ! Closing now.

Corrie Hutchinson November 13, 2023 at 2:52 PM

  Tested and can confirm disabled parameters do not appear in the UI.  Thanks.  

Charlotte Whitt November 13, 2023 at 8:06 AM

Hi - will you be able to do the test of this ticket today? We need to wrap up the work we have on the Poppy Bugfest dash board. Thanks a ton.

Mike Taylor November 7, 2023 at 8:48 AM

Note that in https://github.com/MikeTaylor/dummy-ldp-queries/blob/26dec88f2e37357fa0f443c1e347173548eb1ad0/queries/mikes_query.json#L53 the parameter with display-name "Institution permanent location filter" is disabled.

Now load that query "Mike's copy of Count loans and renewals" in the Run report tab of the Reporting app, and note that the field does not appear.

I don't know what else you're expected to do by way of manual testing.

Charlotte Whitt November 2, 2023 at 1:17 PM

Hi - please do the manual testing of this ticket, and then we can close it.

Done

Details

Assignee

Reporter

Tester Assignee

Labels

Priority

Sprint

Development Team

Thor

Fix versions

Release

Poppy (R2 2023) Bug Fix

RCA Group

TBD

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created October 23, 2023 at 3:04 PM
Updated November 13, 2023 at 5:30 PM
Resolved November 13, 2023 at 5:30 PM
TestRail: Cases
TestRail: Runs