Validate Item Record

Description

Purpose: Implement basic item record validation

Scenarios:

  1. Scenario

    • Given a new or edited item record

    • When Title is not specified

    • Then the field should display the following validation error: "Please fill this in to continue"

  2. Scenario

    • Given a new or edited item record

    • When Material type is not specified

    • Then the field should display the following validation error: "Please select to continue"

  3. Scenario

    • Given a new or edited item record

    • When Barcode is not specified

    • Then the no validation error should be displayed (this field is optional - Marc is going to change this in the schema)

  4. Scenario

    • Given a new or edited item record

    • When Loan type (permanent) is not specified

    • Then the field should display the following validation error: "Please select to continue"

  5. Scenario

    • Givena new or edited item record

    • When Loan type (temporary) is not specified

    • Then the no validation error should be displayed (this field is optional)

Environment

None

Potential Workaround

None

Attachments

1
  • 27 Jun 2017, 12:35 PM

Checklist

hide

TestRail: Results

Activity

Show:

Charlotte Whitt June 30, 2017 at 4:05 PM

Tested in http://folio-testing.aws.indexdata.com/ version: item-storage 3.0 - by using Chrome.
Labels, error messages and mandatory fields - all looks good

Cate Boerema June 27, 2017 at 4:13 PM

, do you think we already have what we need to ensure that imported data is valid (for user data) or should we get in a story for that?

Mike Taylor June 27, 2017 at 4:10 PM

I don't know what the back-end guys have planned, exactly. But my expectation would be that the Ingest service will validate the records according to some set of criteria, which may or may not be the same as those we use for manual user-record creation; and that records that fail that validation will be discarded and a report generated.

As always, the back-end tells the real truth about what may and may not be stored, both for bulk import and for manual user creation. Client-side validation, whether done with or without reference to server-provided facilities, is only a convenience – like client-side permission checking.

Marc Johnson June 27, 2017 at 4:04 PM
Edited

When I suggested that the validation was performed on the client (the UI), I was referring only to the per-field validation in the users UI module (which I thought had been done by a request to the server), rather than validation for a user in general. I believe there is record validation in the users module. Apologies for any confusion caused by the distinction.

Cate Boerema June 27, 2017 at 3:59 PM

So there is validation in the import (or in something the import uses)? I was reading the earlier comments and concluding that the validation was all in the UI and thinking the import would, then, bypass the validation. I may have misunderstood.

Done

Details

Assignee

Reporter

Priority

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created May 24, 2017 at 10:22 AM
Updated July 11, 2017 at 12:51 PM
Resolved June 30, 2017 at 4:07 PM
TestRail: Cases
TestRail: Runs