Cannot edit material-type or either loan-type for items

Description

It seems we must send the material-type UUID when changing the MT of an item. It does not suffice to send the MT name, as the present code does.

(See MODINV-4.)

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Matt Connolly May 30, 2017 at 1:33 PM

Yes ... Niels's explanation makes sense. While using a lookup table every time we need a label seems klutzy, at least the data is already available from populating the drop-downs. I'll go ahead and implement that for the remaining types.

Mike Taylor May 30, 2017 at 1:27 PM

Thanks.

But it seems a bit perverse not to use the translated data when it's right there.

I guess we already need to lookup table to provide the dropdown list that we're picking from, though – right?

Matt, do you have everything you need now?

Niels Erik Nielsen May 30, 2017 at 1:21 PM

Yeah, don't use the label from the back-end for display in a scenario where data can be mutated. The label is redundant data and thus susceptible to this kind of error.

Use a look-up table instead – like Matt does already for the permanent loan type.

Mike Taylor May 30, 2017 at 1:10 PM

Can you see a good, clean, idiomatic fix?

Done

Details

Assignee

Reporter

Priority

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created May 8, 2017 at 11:00 AM
Updated June 7, 2017 at 10:00 AM
Resolved May 30, 2017 at 7:23 PM
TestRail: Cases
TestRail: Runs