Preceding titles enhancements to "connected" title (create, edit)
CSP Request Details
None
CSP Rejection Details
None
CSP Approved
None
Description
Purpose: The thin thread implementation of preceding titles assumed that all preceding titles would be found in an institutions' inventory. As it turns out, institutions really need the ability to ALSO specify titles that are not in Inventory. The purpose of this story is to rework the current functionality so it supports this use case. NOTE the functionality described here is based losely on a similar implementation in PO Lines. To test how things work in PO lines, go to Settings > Orders > PO line limits and set limit to 5. Then go to Orders and select an order (not a PO line) with status = pending. Scroll down on the order in view mode and click "Add PO line" button. Then play around with the Title, Publisher and Publication date fields. These are analogous to Title, ISBN and ISSN in our case.
Scenarios:
Scenario
Given the Title data section of the Instance record (create and edit)
When displayed
Then the "Preceding titles" sub-section should display as shown in the mockups
NOTE: section should not display in a "Related titles" sub-section (that sub-section, which only currently displays in create and edit, should be removed) CB: I don't want to hold up the release on this tiny thing. I'll create a separate bug for this.
Scenario
Given the "Add preceding title" button
When clicked
Then an empty row should be added including these fields:
Title * - uneditable
Instance HRID - should display uneditable with the text "N/A"
ISBN - uneditable
ISSN - uneditable
NOTE: These fields will be uneditable for now. When we implement UIIN-950, we'll make them editable (see scenario 1)
Given the Title field
When displayed
Then a plus icon should display as shown in the mockup
Scenario
Given the plus icon
When clicked
Then the instance search and select popup should display
CB: We will use the existing instance search and select component.
CW - I have created a bug report on the modal being outdated - see: UIPFI-6 PO lines. The Inventory look up modal is not the current view. Filed 12/17/2019
Scenario
Given the instance search and select popup is displaying
When an instance is selected
Then:
The popup should close
The Title, Instance HRID, ISBN and ISSN fields should auto-populate with the data from the selected instance
All fields should become read-only
If there is >1 ISBN or ISSN on the instance record, display all of them separated by commas CB: Probably should have specified that they should be separated by comma followed by a space. Can create a follow up issue for that.
"Connected" text should display above the Title field as shown in the mockup CB: I think this is too big/bold, but we can create a follow-up issue for it
Title should be link to connected instance record
It is not possible at this time to make this row "not connected"
NOTE: The use case for converting a connected title to a disconnected one is when a connected title is very old and the library wants to delete the inventory instance. Current thinking is that, when inventory instances are deleted, any preceding or succeeding titles related to that instance will be converted to disconnected titles (and the Title, HRID, ISSN and ISBN will be copied/saved in the referencing record)
Scenario
Given Instance X is linked to Instance Y as a preceding title
When Instance X's Title, HRID, ISBN or ISSN are updated
Then the data displaying in Instance Y should also update
Scenario
Given a preceding title has been selected from Inventory instances
When the plus icon is clicked and a new instance is selected
Then the Title, HRID, ISBN and ISSN data should update to that of the newly selected instance.
Other comments: This story replace previous filed stories: Instance Record. Preceding title. Populate data (detailed view) and Instance Record. Look up Preceding title (edit mode)
Thanks . Yes I noticed that flashing too. I think in order to fix it we would have to refactor the entire instance form (which we should do at some point). Thanks for testing this!
Cate BoeremaMarch 13, 2020 at 3:36 PM
Hi I think this is looking good except for the small issues noted in the story. But we can create follow-on issues for them. I will close this for now and make a note to review the comments later and create follow-on issues.
Another weird thing we can fix later is that, right after you save, the page flashes an empty preceding titles row and you momentarily think that the data was cleared out, but then it saves as expected.
Thanks - I'll move onto the other stories now.
FYI and
Michal KuklisMarch 13, 2020 at 1:25 PM
and this should be now fixed. I also removed the "Related titles" section. I believe this should be available in folio-testing at some point today.
Michal KuklisMarch 13, 2020 at 1:15 PM
Edited
Thanks for testing this. Sorry I should have marked this as "In Code Review". I discovered couple additional issues when working on succeeding titles. I'm trying to address them right now. After that we should be able to test all these stories.
Purpose: The thin thread implementation of preceding titles assumed that all preceding titles would be found in an institutions' inventory. As it turns out, institutions really need the ability to ALSO specify titles that are not in Inventory. The purpose of this story is to rework the current functionality so it supports this use case. NOTE the functionality described here is based losely on a similar implementation in PO Lines. To test how things work in PO lines, go to Settings > Orders > PO line limits and set limit to 5. Then go to Orders and select an order (not a PO line) with status = pending. Scroll down on the order in view mode and click "Add PO line" button. Then play around with the Title, Publisher and Publication date fields. These are analogous to Title, ISBN and ISSN in our case.
Scenarios:
Scenario
Given the Title data section of the Instance record (create and edit)
When displayed
Then the "Preceding titles" sub-section should display as shown in the mockups
NOTE: section should not display in a "Related titles" sub-section (that sub-section, which only currently displays in create and edit, should be removed) CB: I don't want to hold up the release on this tiny thing. I'll create a separate bug for this.
Scenario
Given the "Add preceding title" button
When clicked
Then an empty row should be added including these fields:
Title * - uneditable
Instance HRID - should display uneditable with the text "N/A"
ISBN - uneditable
ISSN - uneditable
NOTE: These fields will be uneditable for now. When we implement UIIN-950, we'll make them editable (see scenario 1)
Given the Title field
When displayed
Then a plus icon should display as shown in the mockup
Scenario
Given the plus icon
When clicked
Then the instance search and select popup should display
CB: We will use the existing instance search and select component.
CW - I have created a bug report on the modal being outdated - see: UIPFI-6 PO lines. The Inventory look up modal is not the current view. Filed 12/17/2019
Scenario
Given the instance search and select popup is displaying
When an instance is selected
Then:
The popup should close
The Title, Instance HRID, ISBN and ISSN fields should auto-populate with the data from the selected instance
All fields should become read-only
If there is >1 ISBN or ISSN on the instance record, display all of them separated by commas CB: Probably should have specified that they should be separated by comma followed by a space. Can create a follow up issue for that.
"Connected" text should display above the Title field as shown in the mockup CB: I think this is too big/bold, but we can create a follow-up issue for it
Title should be link to connected instance record
It is not possible at this time to make this row "not connected"
NOTE: The use case for converting a connected title to a disconnected one is when a connected title is very old and the library wants to delete the inventory instance. Current thinking is that, when inventory instances are deleted, any preceding or succeeding titles related to that instance will be converted to disconnected titles (and the Title, HRID, ISSN and ISBN will be copied/saved in the referencing record)
Scenario
Given Instance X is linked to Instance Y as a preceding title
When Instance X's Title, HRID, ISBN or ISSN are updated
Then the data displaying in Instance Y should also update
Scenario
Given a preceding title has been selected from Inventory instances
When the plus icon is clicked and a new instance is selected
Then the Title, HRID, ISBN and ISSN data should update to that of the newly selected instance.
Mockups: https://drive.google.com/drive/folders/1OTQ6h5hR7DN-Ujlb2VILcJNITIsbSQvG
Other comments: This story replace previous filed stories: Instance Record. Preceding title. Populate data (detailed view) and Instance Record. Look up Preceding title (edit mode)