"Show requests in queue" shows all requests at first

Description

Steps:
Go to the Requests app and make sure no requests are open (the app is blank)
Go to the Inventory app and open an item record
Add two requests to the item
After adding the second requests, under "Position in queue" select "view requests in queue"

Expected behavior:
Only requests for the item in question are displayed

Actual behavior:
In the BugFest instance, about 100 requests are displayed, including some for different items.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Ann-Marie Breaux October 16, 2019 at 6:05 AM

Hi Tested on folio-snapshot. All looks fine now. Closing this ticket.

Michal Kuklis October 14, 2019 at 2:50 PM

that sounds like a separate issue to me.

patty.wanninger October 10, 2019 at 9:44 PM

, Can you take this out of in review? It is working in Snapshot as long the item has a barcode. If you place a queue of requests on an on order item, no queue is created. Is that a separate issue?

Michal Kuklis October 7, 2019 at 8:33 PM
Edited

It looks like this is a bigger issue related to syncing between url params and resource query. Here is what is happening currently:

1. The Link is clicked
2. This triggers resource sync in stripes connect because previous location != current location:
https://github.com/folio-org/stripes-connect/blob/master/connect.js#L143
3. The fetch is executed and it goes down to makeQueryFunction. makeQueryFunction returns null because the query and filters are empty in resource query (and we are currently not checking location based params)
4. The fetch aborts here: https://github.com/folio-org/stripes-connect/blob/master/RESTResource/RESTResource.js#L538
and redux store is updated with an abort message which triggers https://github.com/folio-org/stripes-core/blob/master/src/components/MainNav/MainNav.js#L83
5. The updateLocation is executed and as a consequence a wrong url is being pushed to the history.

This is a bit crazy and I'm not sure how to approach it yet. I think the easiest would be to replace Link with:

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Prokopovych

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created September 19, 2019 at 7:19 PM
Updated October 16, 2019 at 6:05 AM
Resolved October 16, 2019 at 6:05 AM
TestRail: Cases
TestRail: Runs