ECS | Counters of "Shared" facet options count Instances with empty Item's "Effective call number" field

Description

Overview: Counters of "Shared" facet options count Instances with empty Item's "Effective call number" field.
NOTE: the fix should be applied for each call number browse option

Steps to reproduce:

  1. Log in into ECS Quesnelia bugfest environment as admin user.

  2. Switch active affiliation to “College” (member) tenant.

  3. Go to “Inventory” >> “Browse”

  4. Select “Superintendent of Documents classification" browse option

  5. Run any browse, ex. “Test”

  6. Expand “Shared” accordion and note values in counters next to the options

  7. Select “Search” tab in “Search|Browse” toggle

  8. Create a new Instance:
    Click on the “Actions” >> “New local record” >> Fill required fields >> Click on the “Save & close”

  9. Create a new Holdings for created Instance:
    Click on the “Add holdings” >> Fill required fields >> Click on the “Save & close” button

  10. Add an Item to the created “Holdings” and select “Superintendent of Documents classification" call number type:
    - Click on the “Add item”
    - Select “Superintendent of Documents classification" in “Call number type” dropdown
    - Fill required fields (don’t fill “Call number” field)
    - Click on the “Save & close” button

  11. Go to “Inventory” >> “Browse”

  12. Select “Superintendent of Documents classification" browse option

  13. Run any browse, ex. “Test”

  14. Expand “Shared” accordion and note values in counters next to the options

Expected result: Counters of “Shared” facet options didn't change.
We shouldn’t count “Instances” with “Holdings” and “Items” with empty "Effective call number" field.

Actual result: Counter of “No” option is increased.

See attached screencast:

MSEARCH-737_issue.webm

Additional information:
Looks like counters of “Shared” facet for “Call numbers (all)” were increased after one more Instance record creation
Looks like counters of “Shared” facet “Superintendent of Documents classification" were increased Item record creation with selected call number type but empty “Call number” field.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

2

Checklist

hide

Activity

Show:

Valery_PilkoApril 30, 2024 at 8:47 AM

Verified on https://bugfest-quesnelia-consortium.int.aws.folio.org - works as expected, except “Local” browse option.
”Local” browse option will be tested after https://folio-org.atlassian.net/browse/MSEARCH-738 is done.
I’m closing this issue.
cc:

JenkinsNotificationsApril 29, 2024 at 2:49 PM

Deployed to the Quesnelia bf env. Moved status to In bugfix review from status Awaiting deployment. Please proceed with the verification.

Valery_PilkoApril 26, 2024 at 12:20 PM

Verified on ECS Sprint testing environment - works as expected, except “Local” browse option.
”Local” browse option will be tested after https://folio-org.atlassian.net/browse/MSEARCH-738 is done.
See attached screencast:

UIIN-2876_verified_sprint_testing.webm

Natalia ZaitsevaApril 26, 2024 at 10:40 AM

Should be tested after https://folio-org.atlassian.net/browse/UIIN-2871 as it contains fixes related to this issue.

Viacheslav KolesnykApril 25, 2024 at 10:30 AM

Changing request “query” parameter from callNumberType="sudoc" to callNumberType="sudoc" AND items.effectiveShelvingOrder="" NOT items.effectiveShelvingOrder=="" fixes the issue. Verified via Postman. Wait for the implementation of https://folio-org.atlassian.net/browse/UIIN-2871

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Spitfire

Fix versions

Release

Quesnelia (R1 2024) Bug Fix

RCA Group

Incomplete/missing requirements

Affected releases

Quesnelia (R1 2024)
Poppy (R2 2023)

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created April 23, 2024 at 10:26 AM
Updated May 21, 2024 at 8:25 PM
Resolved April 26, 2024 at 8:33 PM
TestRail: Cases
TestRail: Runs

Flag notifications