ECS: Effective location facet is not showing other member tenants

Description

Overview: In the ECS environment, there are two issues:

  1. The effective location facet in one tenant is not showing the locations of other tenants. The effective locations of other tenants should show in the facet in both Inventory search and browse. 

  2. The Held-by facet is capping out at 9 locations even though the backend sends more in the response (not discovered in poppy bugfest ECS because there are not more than 9 locations) (new ticket: https://folio-org.atlassian.net/browse/UIIN-2730 )

Steps to Reproduce:

  1. Log into into ECS Poppy bugfest environment 

  2. Switch affiliation to University tenant 

  3. Select "Yes" in the "Shared" facet

  4. Identify a shared instance (such as HRID cenin00000480881) with holdings from College tenant - note the location of the holdings

  5. Add holdings/item for University tenant in the "Film/Fiche" permanent location

  6. Switch affiliation to the College tenant 

  7. Search for the Shared instance 

  8. Open the "Effective location (item)"

  9. Search for the "Film/Fiche" location

Expected Results: Effective location from University should show in the facet

Actual Results: Only effective locations from the College tenant are showing in the facet

Additional Information:
URL: https://bugfest-poppy-consortium.int.aws.folio.org/inventory/view/d717299d-5d1f-5001-ac4d-8cd20b72d6ed?filters=tenantId.cs00000int_0005&query=cenin00000480881 

CSP Details:

  1. Describe issue impact on business - Issue prevents ECS users from viewing other tenants in the Effective location (item) facet. Users need to be able to view other tenants in conjunction with the Held by facet to evaluate holdings at another member tenant. Without this fix, users will only be able to filter by their current tenant context's locations. 

  2. What institutions are affected? (field “Affected Institutions” in Jira to be populated) - All institutions (MOBIUS currently) 

  3. What is the workaround if exists? No workaround

  4. What areas will be impacted by fix (i.e. what areas need to be retested) Inventory search and find instance plugin. 

  5. Brief explanation of technical implementation and the level of effort (in workdays) and technical risk (low/medium/high). Work is complete and the level of effort was medium. The technical risk is low.

  6. Brief explanation of testing required and level of effort (in workdays). Provide test plan agreed with by QA Manager and PO. Test cases already exist and level of effort is 30 minutes.

  7. What is the roll back plan in case the fix does not work? Revert to previous version.

CSP Request Details

Requested CSP approval in Slack 1/16/24 Approved in Slack

CSP Rejection Details

None

Potential Workaround

None

Attachments

9

Checklist

hide

TestRail: Results

Activity

Show:

Valery_PilkoJanuary 11, 2024 at 12:05 PM
Edited

Thank you, Denys!
New Jira created
cc: ,  

Denys BohdanJanuary 11, 2024 at 9:18 AM

Hey , we don't have a way of getting data without permissions. So with current workaround, without back-end effort, in case when user doesn't have permissions in another tenant they won't see locations from that tenant.

We will need a new story and some changes on back-end side to ideally return locations from all tenants in a single endpoint

Valery_PilkoJanuary 11, 2024 at 9:02 AM

Hi and  
During testing, the following issue found:
"Locations from member tenants in which user doesn't have permissions are not shown in "Effective location (item)" and "Holdings permanent location" facets" because if permission error GET "/locations" request.
See attached screencast:

We've discussed this scenario with yesterday and this is an issue.
See Christine's comment at the attached screenshots:

, Do we need a new story to fix it?

cc:  

Valery_PilkoJanuary 10, 2024 at 3:34 PM

Verified on https://bugfest-poppy-consortium.int.aws.folio.org/ 
Issue is fixed - user can see locations in "Effective location (item)" and "Holdings permanent location" facets, from member tenants in which he has permissions to view instances, holdings, and items.
See attached screencasts:

Hi  
Please review the fix on environment.

Natalia ZaitsevaJanuary 10, 2024 at 1:59 PM

deployed to BugFest

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Spitfire

Fix versions

Release

Poppy (R2 2023) Service Patch #1

CSP Approved

Yes

RCA Group

Incomplete/missing requirements

Affected releases

Poppy (R2 2023)

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created December 22, 2023 at 1:43 PM
Updated January 25, 2024 at 3:39 PM
Resolved December 29, 2023 at 11:37 AM
TestRail: Cases
TestRail: Runs