Optimistic locking message not working for instances in non-consortial tenant

Description

Overview: Optimistic locking message for an instance in a non-consortial tenant is not displaying properly. This may relate to the work being done on MODINV-860.

Steps to Reproduce:

  1. Log into Snapshot as a user with Inventory permission to edit instances

  2. Go to Inventory

  3. Find an existing instance

  4. Open the instance details

  5. Open a second window and copy/paste the first screen's URL into the second window

  6. In both windows, click Action/edit instance to get to the Instance editing screen

  7. In the first window, assign or change the instance status. DO NOT press save yet

  8. In the second window, add a statistical code to the instance

  9. Press save in the second window and confirm that the instance was updated, with the statistical code added to it

  10. Go back to the first window and press save

Expected Results: User receives a message that this is not the most recent version of the instance, and an option to view the latest version or cancel.

Actual Results: User receives a pop-up message, but it does not have the proper information in it.

Additional Information:

  • This works properly for holdings and items. Only instances are having a problem

  • This works properly in Orchid, so something has regressed in Poppy

  • Video and correct alert message versus incorrect alert message attached

Testing details

  • Review the optimistic locking tests already in TestRails - determine if we need to add any for the various scenarios listed below

Note that optimistic locking must work as follows:

  • Non-consortial tenant

    • For instances, holdings, and/or items being edited at the same time by

      • The same user with 2 windows open

      • Two or more users

  • Consortia central tenant

    • For shared instances being edited at the same time by

      • A user in central tenant and the same user in a member tenant

      • The same user in 2 different member tenants

      • One user in central tenant and a different user in a member tenant

      • Two different users in two different member tenants

  • Consortia member tenant

    • For shared instances being edited at the same time by

      • A user in central tenant and the same user in a member tenant

      • The same user in 2 different member tenants

      • One user in central tenant and a different user in a member tenant

      • Two different users in two different member tenants

    • For one member tenant's holdings being edited at the same time by

    • The same user with 2 windows open

    • Two or more users in the same member tenant

    • For one member tenant's item being edited at the same time by

    • The same user with 2 windows open

    • Two or more users in the same member tenant

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

3

Checklist

hide

TestRail: Results

Activity

Show:

Ann-Marie Breaux November 10, 2023 at 7:04 AM

Tested on Poppy BF - looks good! Closing this

JenkinsNotifications November 7, 2023 at 6:05 PM

Deployed to the Poppy bf env. Moved status to In bugfix review from status Awaiting deployment. Please proceed with the verification.

Ann-Marie Breaux November 6, 2023 at 4:42 PM

Hi Looks good - thank you for fixing! Moving this to Awaiting release

Svetlana Amirova November 6, 2023 at 1:22 PM

Hello  

Ticket verified on Folijet Rancher. Optimistic locking message for instances works as expected. Moving ticket to In Review.

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Folijet

Fix versions

Release

Poppy (R2 2023) Bug Fix

RCA Group

Legitimate regression

Affected releases

Poppy (R2 2023)

Affected Institution

!!!ALL!!!

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created October 16, 2023 at 5:22 PM
Updated November 10, 2023 at 7:04 AM
Resolved November 6, 2023 at 4:42 PM
TestRail: Cases
TestRail: Runs