Overview: After https://folio-org.atlassian.net/browse/MODINV-829#icft=MODINV-829 was fixed then a new problem might have been introduced and is seen in Cornell's test environment and in Bugfest Orchid. It's happening when there are 100 items or more

See videos from Cornell's environment:

Steps to Reproduce:

1. Log into FOLIO Bugfest Orchid environment as User folio (password: folio)

2. Go to Inventory, in the Holdings segment select search on Holdings HRID

3. Search for Holdings HRID: ho28708

4. The instance title Accountancy displays and the holdings with 103 items are listed in the top of the instance record in the third pane

5. Display the item list

6. Click on any item

Expected Results:
The item displays in detailed view.

Actual Results:
Get an error message saying: "ERROR: in module @folio/inventory, operation GET on resource 'instanceRecords' failed, saying: Not Found"

Open

Additional Information: The mod-inventory fix (https://folio-org.atlassian.net/browse/MODINV-829#icft=MODINV-829) was deployed to bugfest Orchid on 6/29:
URL: https://bugfest-orchid.int.aws.folio.org/inventory/view/9da417a0-c26d-4d87-be32-907fdcefe8dc?qindex=hrid&query=ho28708&segment=holdings&sort=title
Interested parties: @Thomas Trutt

Description of what was done in this Jira
@Maccabee Levine submitted the patch for code review that should mitigate this problem. It will not actually solve the underlying issue, but should work with

• any holding record that has no bound-with items, regardless of how many normal items it has. I tested with 500+.

• any holding record that has a mix of directly-linked and bound-with items, as long as there are not more than 300 unique holdings records directly linked to those items.

• Details in the PR.

Orchid Bugfest Instances with Many Items

• Instance in190451 (103 items)

• Instance in794997 (24,000+ items)

• Instance in2386991 (5,953 items)

CSP justification

Describe issue impact on business

Unable to complete requests for any holdings record that contain over a 100 items. 

What institutions are affected? (field “Effected Institutions” in Jira to be populated)

Any institutions that have a holdings record that contain over a 100 items 

What is the workaround if exists?

No reasonable workaround 

What areas will be impacted by fix (i.e. what areas need to be retested)

• GET holdings for an instance record 

• GET items for a holdings record

Brief explanation of technical implementation and the level of effort (in workdays) and technical risk (low/medium/high)

• Description is in comments.

• LOE: 3 days 

• Risk: Low 

Brief explanation of testing required and level of effort (in workdays). Provide test plan agreed with by QA Manager and PO.

 Test plan:

• Generate a holdings record with more than 100 but less than 1000 items 

• Verify that user can view all items tied to the holdings record 

• Verify that user can view the holdings record and items record 

• Verify with / without bound-withs 

Tests

• New test:

  • Need to add tests

• Existing tests (for regression testing):

  • No existing tests exists for a large set of records. 

What is the roll back plan in case the fix does not work?

• Revert change