Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Cannot save new Z39.50 Settings profile due to missing required fields

Description

Overview: Cannot create a new Z39.50 profile with just a name. This worked yesterday! See TestRail https://foliotest.testrail.io/index.php?/cases/view/374178 and

Steps to Reproduce:
Scenario 1 Check Mark

  1. Log into Snapshot

  2. Go to Settings/Inventory/Integrations/Z39.50 target profiles

  3. Create a new target profile by clicking +New button

  4. Assign a name for the profile

  5. Click Save & close

Scenario 2 Check Mark

  1. Log into Snapshot

  2. Go to Settings/Inventory/Integrations/Z39.50 target profiles

  3. Create a new target profile by clicking +New button

  4. Assign a name for the profile

  5. Click Add job profile for import/create

  6. Assign the Inventory Single Record - Default create instance job profile

  7. Click Save & close

Expected Results: In both scenarios, the Z39.50 profile is created

Actual Results: In both scenarios, the Z39.50 profile creation fails

Additional Information: See attached video UIIN-2298 Z39.50 profile error.mp4. Failure seems to be related to the "default" radio button not being set. That was not triggering an error yesterday, so I'm not sure what changed between now and then

TO RESOLVE See attached screenshot Make required.png Check Mark

  • Make the Job profiles for import/create and Job profiles for overlay/update required fields (red asterisk, and standard error/disallow save unless at least one job profile is selected for each.

  • Make sure that one job profile in each section has the default radio button enabled. Add a red asterisk for the default field if necessary. Standard error/disallow save unless one job profile in each section is marked as default.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

3
  • 01 Feb 2023, 10:37 AM
  • 18 Jan 2023, 06:48 AM
  • 11 Jan 2023, 07:03 AM

Checklist

hide

TestRail: Results

Activity

Show:

Ann-Marie BreauxFebruary 6, 2023 at 7:18 PM

Hi and Tested on Snapshot and all looks good - updated the TestRail slightly. Thank you!

Maksym IshchenkoFebruary 1, 2023 at 10:38 AM

Hi  

Task passed on snapshot env. User can't create/edit target profile without assigned job profiles. Required asteriks present on create/edit screen. Moving to In Review column. 

Test case updated too.

Screencast: https://issues.folio.org/secure/attachment/57168/UIIN-2298_Verified.mp4

cc:  

 

Ann-Marie BreauxJanuary 18, 2023 at 6:50 AM

Hi and I added a fix at the end of this bug, plus a mockup. Please let me know if questions.

Once this is fixed, please update the linked TestRail to add steps for selecting job profiles for import/create and overlay/update

Thank you!

Kateryna SenchenkoJanuary 11, 2023 at 11:03 AM

Hi , that's the default validation that protects API against saving the profile without the default JobProfiles selected. I think we discussed at some point that we should indeed have such kind of validation. Should we change that? I believe there might have been a problem in RMB or elsewhere that caused validation to be disabled, hence the profile could be saved without required fields before. 

Another issue is that default is not selected, should we mark the first selected profile as default?

Let's talk about it in refinement, we might need to make adjustments in current error handling mechanism and make the required fields apparent for the user. 

Thank you!

Done

Details

Assignee

Reporter

Labels

Priority

Story Points

Sprint

Development Team

Folijet

Parent

Fix versions

Release

Orchid (R1 2023)

RCA Group

Requirements change

Affected releases

Orchid (R1 2023)

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created January 11, 2023 at 6:49 AM
Updated February 20, 2023 at 2:47 PM
Resolved February 6, 2023 at 7:19 PM
TestRail: Cases
TestRail: Runs

Flag notifications