Validation for unique barcode broken in Item form

Description

Non-unique bar codes are accepted in the form, and eventually rejected by the back-end.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Niels Erik Nielsen May 30, 2018 at 4:37 PM

Awesome, thanks . Done.

John Malconian May 30, 2018 at 2:40 PM

Error caused by Postgres max connection limit exceeded. I've doubled the connection capacity and reran the job and it has succeeded. Ready for merge.

https://github.com/folio-org/ui-inventory/pull/197

Niels Erik Nielsen May 30, 2018 at 11:32 AM

Fixes pushed but cannot currently merge:

TASK [mod-inventory-data : Check for sample instances] ************************* fatal: [localhost]: FAILED! => {"accept": "application/json", "accept_encoding": "identity", "authtoken_refresh_cache": "true", "changed": false, "connection": "close", "content": "ErrorMessage(fields=Map(Line -> 779, File -> postinit.c, SQLSTATE -> 53300, Routine -> InitPostgres, V -> FATAL, Message -> remaining connection slots are reserved for non-replication superuser connections, Severity -> FATAL))", "content_type": "text/plain", "host": "folio-snapshot-stable.aws.indexdata.com:9130", "msg": "Status code was 500 and not [200]: HTTP Error 500: Internal Server Error", "redirected": false, "status": 500, "transfer_encoding": "chunked", "url": "http://folio-snapshot-stable.aws.indexdata.com:9130/instance-storage/instances", "user_agent": "ansible-httpget", "x_okapi_permissions": "[\"inventory-storage.instances.collection.get\"]", "x_okapi_request_id": "763908/instance-storage", "x_okapi_tenant": "pr_197_1", "x_okapi_token": "eyJhbGciOiJIUzUxMiJ9.eyJzdWIiOiJwcl8xOTdfMV9hZG1pbiIsInVzZXJfaWQiOiI3MWRmMWQzOS0xM2JkLTRlN2QtYTdhYi01NmU3MjBhMTEzOWIiLCJ0ZW5hbnQiOiJwcl8xOTdfMSJ9.ZQ-wWt1D5s7qIQjpXl3z1dwuMEC62hC1GNl9uQTaRB_IJh1-w-bNvfv0Oiqnc2n5OxPwJm-a6HO4zyRweWjvWQ", "x_okapi_trace": "GET mod-authtoken-1.4.1-SNAPSHOT.21 http://10.36.1.37:9135/instance-storage/instances : 202 276866us, GET mod-inventory-storage-11.0.0-SNAPSHOT.116 http://10.36.1.37:9139/instance-storage/instances : 500 20373us", "x_okapi_url": "http://10.36.1.37:9130", "x_okapi_user_id": "71df1d39-13bd-4e7d-a7ab-56e720a1139b"} to retry, use: --limit @/home/jenkins/workspace/folio-org/ui-inventory/PR-197/folio-infrastructure/CI/ansible/folioci-pr.retry PLAY RECAP ********************************************************************* localhost : ok=9 changed=1 unreachable=0 failed=1 FATAL: command execution failed hudson.AbortException: Ansible playbook execution failed at org.jenkinsci.plugins.ansible.AnsiblePlaybookBuilder.perform(AnsiblePlaybookBuilder.java:262) at org.jenkinsci.plugins.ansible.workflow.AnsiblePlaybookStep$AnsiblePlaybookExecution.run(AnsiblePlaybookStep.java:400) at org.jenkinsci.plugins.ansible.workflow.AnsiblePlaybookStep$AnsiblePlaybookExecution.run(AnsiblePlaybookStep.java:321) at org.jenkinsci.plugins.workflow.steps.AbstractSynchronousNonBlockingStepExecution$1$1.call(AbstractSynchronousNonBlockingStepExecution.java:47) at hudson.security.ACL.impersonate(ACL.java:290) at org.jenkinsci.plugins.workflow.steps.AbstractSynchronousNonBlockingStepExecution$1.run(AbstractSynchronousNonBlockingStepExecution.java:44) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) Ansible playbook execution failed

Niels Erik Nielsen May 30, 2018 at 11:07 AM

The check returns SubmissionError, which doesn't seem to be picked up (anymore?) for async validations.

Also, unrelated, the check uses partial match (=), which is wrong, should be exact match (==)

Done

Details

Assignee

Reporter

Labels

Priority

Development Team

Other dev

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created May 29, 2018 at 2:20 PM
Updated November 3, 2023 at 2:54 PM
Resolved May 30, 2018 at 4:37 PM
TestRail: Cases
TestRail: Runs

Flag notifications