Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Disable sorting by "relation" column

Description

Overview:

Disable sorting by the "relation" column because this cannot work as there is no "relation" property.

Steps to Reproduce:

  1. Click on the "relation" column head

  2. This enables sorting by "relation" or toggles its ascending/descending sort order.

However, the "relation" entries don't get sorted.

Neither mod-inventory nor mod-inventory-storage have a "relation" property in the instance record. Sorting by a non-existing property requires a full table scan resulting in bad performance but does not result in the expected order. Example query:

https://folio-goldenrod-okapi.dev.folio.org/inventory/instances?limit=100&query=(keyword all "a*") sortby relation/sort.descending

The front-end should disable the sort option for the "relation" column.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

4
  • 15 Jan 2021, 02:40 PM
  • 23 Oct 2020, 03:15 PM
  • 22 Oct 2020, 04:52 PM
  • 22 Oct 2020, 12:24 PM

Checklist

hide

TestRail: Results

Activity

Show:

Charlotte WhittJanuary 15, 2021 at 2:40 PM

Manual test in FOLIO Snapshot version @folio/inventory 5.0.10001121, using Chrome.

This change has been verified. Looks good. Thanks.

Zak BurkeOctober 23, 2020 at 4:46 PM

The MCL component has nonInteractiveHeaders and onHeaderClick props that are likely key here.

Cate BoeremaOctober 23, 2020 at 3:15 PM

Okay. Apparently this column populates with the relationship type. We haven't tested what it displays when there is more than one

Julian LadischOctober 22, 2020 at 4:52 PM

The relation column contains instance relationships:

Cate BoeremaOctober 22, 2020 at 12:24 PM

and , if there is no Relation property on the instance record, do we even want the column to display in the search results? Won't it always be empty?

Done

Details

Assignee

Reporter

Tester Assignee

Labels

Priority

Story Points

Sprint

Development Team

Prokopovych

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created October 20, 2020 at 12:51 PM
Updated January 15, 2021 at 2:41 PM
Resolved January 15, 2021 at 2:41 PM
TestRail: Cases
TestRail: Runs

Flag notifications