Remove Inline Editing - Title+Package Show
Priority
Labels
Environment
Template
Description
Development Team
Release
Story Points
Sprint
Attachments
is cloned by
relates to
Checklist
hideTestRail: Results
Activity

Carole GodfreyMay 31, 2018 at 1:18 PM
All fields have been made read only with the exception of custom coverage dates. To be addressed in separate ticket. Ticket should also confirm proper operation of isSelected toggle with other fields

Carole GodfreyMay 29, 2018 at 2:08 PMEdited
Status (5/27)
Completed removal for Visibility and Coverage Statement - PRs have been merged
In Progress with removal of custom embago - should be able to get a PR out for that today (plan to fix https://folio-org.atlassian.net/browse/UIEH-387 as part of this PR)
https://github.com/folio-org/ui-eholdings/pull/413 - addresses theseRemoval of custom coverage dates will most likely not make it - ran into issues with this functionality and not removing until it is fixed
Also need to verify functionality for isSelected settings clearing out values

Carole GodfreyMay 24, 2018 at 11:30 PM
Added update for coverage statement - https://github.com/folio-org/ui-eholdings/pull/410

Carole GodfreyMay 23, 2018 at 7:11 PM
The following PR - incorporates changes for Visibility https://github.com/folio-org/ui-eholdings/pull/408.
Visibility can only be edited when in full page edit mode. Show page displays text regarding visibility.
Note – Review of this PR noted some issues with clearing out resource values when setting isSelected to false for managed resources. Specifically
model.identifiersList = [];
model.identifiers = {};
Looking at redux layer and mod-kb-ebsco – setting model.identifiers = [] is correct.
Need to review the clearing of resource values in general when setting isSelected to false to be sure we are resetting properly and covering all cases.

Carole GodfreyMay 17, 2018 at 1:23 PM
I am repointing story from 3 to 5 after more research. Want to be sure that all test cases that I am removing for in-line edit are covered in full page edits for custom and or managed resources
Remove Inline Editing from the Title+Package Detail (View Mode)
The user may only change the selection status of a package-title (resource) from View Mode
All other fields can only be changed when in Full Page Edit mode.
When in view mode show the value entered or a statement that no value has been selected/entered