DI Log: Make some changes to the Log header

CSP Rejection Details

None

CSP Request Details

None

CSP Approved

None

Description

Purpose: To add the job ID and the job profile into the header of the Data Import log, to make the source of the log more clear.

As a staff person working with Data Import logs
I want to be able to tell which job a log belongs to, and which job profile was used for the job
So that I can understand the log screen better

Scenarios

  1. Scenario 1 Check Mark

    • Given the Data Import log

    • When displaying the header

    • Then add "Job n" followed by a dot, before the number of records found (in the subheader)

    • With "n" being the job ID (last column in the log list)

    • See attached mockup

  2. Scenario 2 Check Mark

    • Given the Data Import log

    • When displaying the header

    • Then add a separate row that has "Job profile xyz"

    • With "xyz" being the name of the job profile used for the import

    • See attached mockup

  3. Scenario 3 Check Mark

    • Given the Data Import log

    • When displaying job profile name in the header

    • Then make it a hotlink

    • And when a user clicks it, display the job profile details (the same behavior as when a user clicks the job profile name in the log list)

  4. Scenario 4 Check Mark

    • Given the Data Import log

    • When displaying the log

    • Then add a 20 pixel margin on both sides, so that the log does not go to the very edge of the page

  5. Scenario 5

    • Given the Data Import Holdings JSON screen

    • When viewing older logs (for imports created before these log changes)

    • Then ensure there are no error messages or weird-looking UI display

    • NOTE: We cannot test this on Snapshot, since previous import jobs are cleared out every day. To test this, we'll need to do some imports on Folijet Rancher, then implement these changes, and then do some additional imports. When reviewing on Rancher, please add screenshot(s) to this Jira showing what the older logs look like after the changes are merged.

  6. Scenario 6

    • Ensure automated testing coverage for this new code is 80% plus

Release notes

  • Remind SMEs that the hotlink is to the current version of the job profile, but may not be the same details as were used for the import, especially if the import was a while ago

  • What if the job profile was deleted? See UIDATIMP-1450 for how it will be handled

Environment

None

Potential Workaround

None

Attachments

2

Checklist

hide

TestRail: Results

Activity

Show:

Ann-Marie Breaux May 5, 2023 at 6:57 AM

Hi Looks great on Snapshot - thank you!

I'm not quite sure how to do this, but once we set up Poppy Bugfest, we'll need to look at some of the older logs from Orchid/Nolana, and make sure that these log changes have not broken them - the header, job profile hotlink, Discarded/No action change, etc. I don't think it needs to be an ongoing TestRail, but something that we check during Poppy BF setup

Maksym Ishchenko May 3, 2023 at 1:43 PM
Edited

Hello  

This task is verified. New DI Log looks as expected. Moving ticket to "In review" column

Screencast:

cc:  

Ann-Marie Breaux April 21, 2023 at 3:06 PM
Edited

Thanks, Looks good!

Slight update to how the header looks, based on suggestions from Kimie, and using a format that we have in Inventory already. See https://bugfest-orchid.int.aws.folio.org/inventory/view/a86e5e0d-a456-4da8-9eee-78025269b183/3566ca85-0a8e-4e3a-b4cf-e354800c1adf?query=in1391202&segment=instances&sort=title as an example.

Also, could you add the 20 pixel margin that Kimie mentions? I'll add another scenario above. Thank you!

Kimie Kester April 20, 2023 at 9:20 PM
Edited

Hi Attached is a mock-up for your review. Ideally I think it would be nice from a cosmetic standpoint if there could be approximately a 20 pixel margin on the left and right sides of the table, rather than having the table run flush to each side, if possible. Thanks!

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Folijet

Fix versions

Release

Poppy (R2 2023)

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created April 19, 2023 at 6:02 AM
Updated October 13, 2023 at 11:24 AM
Resolved May 5, 2023 at 6:58 AM
TestRail: Cases
TestRail: Runs

Flag notifications