Order field mapping profile: Fix the UI and error message for the fund "Value" field

Description

Overview: If an Order field mapping profile is created with a fund code "Value" field of 100, no error message is displayed, and the order import does not complete properly.

Current workaround: None

Steps to Reproduce:

  1. Log into FOLIO-snapshot-load as diku_admin

  2. Go to Settings/Data import/Field mapping profiles

  3. Create and save the following field mapping profile

    • Name: Order field mapping: Check fund value field

    • Incoming record type: MARC Bibliographic

    • FOLIO record type: Order

    • Purchase order status: "Pending"

    • Vendor: look up and assign GOBI

    • Title: 245$a

    • Product identifiers

      • Click the "Add product ID and product ID type" button

      • Product ID: 020$a

      • Qualifier: 020$q

      • Product ID type: select "ISBN" from the dropdown list

    • Acquisition method: Select any value from the dropdown list

    • Order format: Select "Physical resource" from the dropdown list

    • Receiving status: Select "Pending" from the dropdown list

    • Payment status: Select "Pending" from the dropdown list

    • Receiving workflow: Select "Synchronized" from the dropdown list

    • Vendor reference number

      • Click Add vendor reference number

      • Vendor reference number: 980$c

      • Vendor reference type: Select "Vendor order reference number" from the dropdown list

    • Physical unit price: 980$m

    • Quantity physical: 980$q

    • Currency: Select "USD" from the dropdown list

    • Fund distribution

      • Click "Add fund distribution"

      • Fund: 980$s

      • Expense class: 980$r

      • Value: 100 (no quotation marks)

      • Type: %

    • Physical resource details/Create inventory: select "None" from the dropdown list

  4. Once saved, view the fund Value field in the field mapping view screen

  5. Create an Action profile for creating orders and link to the above field mapping profile

  6. Create a Job profile for creating orders and link to the above Action profile

  7. Import the attached file TestFundValueFieldMapping.mrc

  8. Click on the completed file name to view the log

Expected Results:

  • Field mapping profile: when the Value 100 is entered without quotation marks, the user should see the standard UI error message (and the field outlined in red) Non-MARC value must use quotation marks

  • Import job: When the file is imported, it should complete without an error

Actual Results:

  • Field mapping profile: There's no error message if Value is entered without quotation marks.

  • Import job: The order import errors, and the JSON error message references the Value field being null.

Additional Information: See attached video and sample MARC file

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

3

Checklist

hide

TestRail: Results

Activity

Show:

Ann-Marie BreauxMarch 28, 2023 at 4:30 AM

Tested on Orchid BF using the attached file and this job profile: https://bugfest-orchid.int.aws.folio.org/settings/data-import/job-profiles/view/8b53eeb9-78c6-4158-8dd6-39067a8ad189?sort=name. All worked as expected

JenkinsNotificationsMarch 24, 2023 at 10:14 PM

Deployed to Orchid BF env. Moved status to In bugfix review from status Awaiting deployment. Please proceed with verification

Ann-Marie BreauxMarch 24, 2023 at 8:12 AM

Hi Tested on Snapshot - looks great and works great - thank you! Moving this to Awaiting release

Elizaveta TsarenkovaMarch 23, 2023 at 1:53 PM
Edited

Hello  

Task verified on snapshot env. Here is the screencast


Moving this issue to "In review" column

cc:  

Ann-Marie BreauxMarch 6, 2023 at 4:39 PM

Hi Per discussion today

  • If value is a number without a subfield (e.g. 900, but not 900$a), then disallow it as a mapping

  • If value is a number with a subfield, then allow it as a mapping

  • Any non-mapping value should have quotation marks around it, or should have the error message about non-MARC mappings needing quotation marks

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Folijet

Fix versions

Release

Orchid (R1 2023) Bug Fix

RCA Group

Implementation coding issue

Affected releases

Orchid (R1 2023)

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created February 24, 2023 at 7:15 AM
Updated March 28, 2023 at 4:30 AM
Resolved March 24, 2023 at 8:12 AM
TestRail: Cases
TestRail: Runs