Error ambiguous when checking item out at service point with no opening hours and loan policy that uses CLDDM

Description

Overview: When you try to check out an item that will get a loan policy that makes use of closed library due date management (CLDDM), the service point you are logged in at has to have hours defined. This makes sense, I guess, but the error that is thrown doesn't give any information about what went wrong.

Steps to repro:

  1. Log into folio

  2. Create a loan policy that uses closed library due date management (i.e. Closed library due date management = anything but "Keep the current due date"

  3. Hook the loan policy into circ rules so it will apply at check out

  4. Create a service point and do not set up any opening hours under Settings > Calendar for that service point

  5. Select that service point and go to check out

  6. Check out an item to a patron so that it gets your loan policy which used CLDDM

Expected: Checkout should not be allowed and error message should display reading:

  • Header: Item not checked out

  • Body: Calendar timetable is absent for requested date.

Actual: Attached is a screenshot of the error message – a modal with title Item not checked out and message "Unknown error occurred".

Additonal info: In the current Bugfest instance, if I use service point Kuggen Infodisk, I can't check out anything (apparently, any item to any user); if I switch the service point to HB Infodisk, everything works fine. Also, if you change the applied loan policy to "Keep the current due date", everything works fine, as well.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

2

Checklist

hide

TestRail: Results

Activity

Show:

Cate Boerema November 12, 2019 at 10:43 AM

From my perspective, it would be fine to start by just displaying the message from the backend. That would be a huge improvement. I can go ahead and modify the expected behavior (they look like something I probably wrote to begin with)

Maxim Didenko November 12, 2019 at 9:03 AM
Edited

, I have one question regarding this bug. At the moment we receive such error message from BE (but it does not display) - "Calendar timetable is absent for requested date". I can replace "Unknown error occurred" with this response, but if we want to use message described in the ticket we need additional BE work in order to get LoanPolicy name which should be displayed in the message. Could you please choose some option?

Cate Boerema September 30, 2019 at 12:00 PM

FYI and

Cate Boerema September 27, 2019 at 11:47 AM

Thanks ! I will see if I can work out some repro steps before discussing with the developers. Putting in Draft for now.

Micah Walter September 26, 2019 at 2:55 PM

Done

Details

Assignee

Reporter

Tester Assignee

Priority

Story Points

Sprint

Development Team

Vega

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created September 26, 2019 at 2:55 PM
Updated December 4, 2019 at 2:59 PM
Resolved November 27, 2019 at 12:50 PM
TestRail: Cases
TestRail: Runs