Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Generate new apps to support Babel 7

Description

ui-app-template is adding a babel-polyfill dependency to new apps that are generated. Now that we run apps under Babel 7, this polyfill is no longer needed, so it should be removed.

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Jason Skomorowski February 19, 2020 at 12:05 AM

It was there so tests could run in the same environment stripes-core provides. The polyfills come from different places now after the migration:
https://github.com/folio-org/stripes-core/pull/780/files#diff-cb86011ded27b35eec449893a2b6a47c

Rather than explicitly have a dev dependency on this for every app, we might consider rexporting something from core. Alternatively, if it doesn't slow down the build overmuch, Babel can handle it for us with more granularity:
https://babeljs.io/docs/en/babel-preset-env#usebuiltins-usage

I suspect the app template will also need to be updated to reflect new versions/packages for our bigtests (eg. miragejs)

Done

Details

Assignee

Reporter

Priority

Sprint

Development Team

Stripes Force

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created February 17, 2020 at 3:26 PM
Updated March 4, 2020 at 7:46 PM
Resolved March 4, 2020 at 7:46 PM
TestRail: Cases
TestRail: Runs