bump stripes to 8.0.0 for Orchid/2023-R1
Description
Environment
Potential Workaround
blocks
Checklist
hideTestRail: Results
Activity
Zak Burke March 9, 2023 at 1:08 PM
@Mikita Siadykh, up to you. You're correct that if this module doesn't touch the API surfaces that are breaking in stripes v8, then you can support both v7 and v8. We have a few repos that chose this option (e.g. ui-courses, stripes-template-editor). It's totally fine; just make sure you test with both, i.e. although you'll have to choose one version to commit in dev-deps, you should manually test with the other.
The peer-dep should be set to sth like ^7 || ^8 but just choose a single version in the dev-deps, which is like saying, "I'm compatible with v7 or v8, but I do my tests with v8".
Mikita Siadykh March 9, 2023 at 3:09 AMEdited
@Zak Burke for bugfix it will be really hard to release major version - it will require releases of at least 4 modules, what do you think about just a patch, in general stripes upgrade doesn't introduce breaking changes in this "library" except major versions to be used together of course?
Details
Details
Assignee
Reporter
Labels
Priority
P3
Summary: Bump the
@folio/stripespeer-dep to8.0.0, including any of its constituent dependencies which are listed as dev-deps. Module versions should be:"@folio/stripes-components": "^11.0.0", "@folio/stripes-connect": "^7.1.0", "@folio/stripes-core": "^9.0.0", "@folio/stripes-final-form": "^7.0.0", "@folio/stripes-form": "^8.0.0", "@folio/stripes-logger": "^1.0.0", "@folio/stripes-smart-components": "^8.0.0", "@folio/stripes-ui": "^1.0.0", "@folio/stripes-util": "^5.2.0",Please note: bumping a peer-dependency is a breaking change; you should bump this package's major version in the PR where this change is merged or immediately before in a separate PR if you wish to separate those concerns.
Attn: @Uladislau Samets, @Magda Zacharska: sorry we missed this in the initial round of tickets attached to https://folio-org.atlassian.net/browse/FOLREL-578#icft=FOLREL-578. My bad. I think this happened because STDTC is a direct-dep of UI applications rather than a peer-dep so it doesn't show up at the platform level. Do you think that's correct, or do you think the platform should directly depend on it and apps should express a peer-dep?