Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

migrate login to react-final-form

Description

We should migrate to final-form in stripes-core. The login form spews out a bunch of console warnings due to an unpatched bug in redux-form (well, patched but unreleased) and this gives a poor first impression for developers evaluating our product.

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Jason Skomorowski October 10, 2019 at 2:57 PM
Edited

I think we should migrate the login form off of redux-form but I don't think we should use final form for it. It's two fields, and one of them, password, is the most sensitive information. So rather than expose it to the whole NPM ecosystem, we should have a goal of shielding it from most (or all) of our dependencies. To that end, we might eventually want to run it in an iframe. That of course is a whole separate project, but for now, if we're refactoring the form, we can make progress towards that goal by sticking to vanilla JS.

A colourful introduction to why we might take that approach:
https://medium.com/hackernoon/im-harvesting-credit-card-numbers-and-passwords-from-your-site-here-s-how-9a8cb347c5b5

Duplicate

Details

Assignee

Reporter

Priority

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created October 9, 2019 at 12:58 PM
Updated October 10, 2019 at 10:43 PM
Resolved October 10, 2019 at 10:43 PM
TestRail: Cases
TestRail: Runs