./lib/commands/platform/pull::pullRepository() calls okToPull() incorrectly
Description
CSP Request Details
None
CSP Rejection Details
None
Potential Workaround
None
Checklist
hideActivity
Show:
Done
Details
Details
Assignee
Zak Burke
Zak BurkeReporter
Zak Burke
Zak BurkeLabels
Priority
Story Points
1
Sprint
None
Development Team
Stripes Force
Fix versions
Release
Ramsons (R2 2024)
RCA Group
TBD
TestRail: Cases
Open TestRail: Cases
TestRail: Runs
Open TestRail: Runs
Created September 17, 2024 at 7:37 PM
Updated February 19, 2025 at 1:13 AM
Resolved October 10, 2024 at 3:56 PM
TestRail: Cases
TestRail: Runs
Summary:
okToPull()
is called with an argument but accepts none.Details: As reported by SonarCloud,
okToPull()
closes over a local variable that is initialized with itsdir
argument;dir
does not need to be passed tookToPull
itself. Functions should not pass unused arguments; this can lead to unintended consequences.