Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

fullText / defaultDictionary not used in queries

Description

For schema creation, schema.json fullText/defaultDicationary is used (variable ft_defaultDictionary): https://github.com/folio-org/raml-module-builder/blob/v26.4.0/domain-models-runtime/src/main/resources/templates/db_scripts/indexes.ftl#L56
This is "english" unless changed in schema.json: https://github.com/folio-org/raml-module-builder/blob/v26.4.0/dbschema/src/main/java/org/folio/rest/persist/ddlgen/FullText.java#L9

But in queries, it's hardcoded to simple.

The query part should use the same dictionary.

In the future we should make it possible to change the dictionary per field and per tenant ("swedish", "german", ...)

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Adam Dickmeiss October 24, 2019 at 10:25 AM

I don't agree. This was/is a breaking change.

Julian Ladisch October 21, 2019 at 9:04 AM

See the explanation on the pull request:

The fullText defaultDictionary option from schema.json is not documented, used by mod-inventory-storage only, and does not work because cql2pg doesn't use it.

Removing undocumented non-working functionality is a bugfix, not a breaking change.

Adam Dickmeiss October 18, 2019 at 10:47 AM

IMHO this is a breaking change, since it actively forces schema.json changes.

Done

Details

Assignee

Reporter

Labels

Priority

Story Points

Sprint

Development Team

Core: Platform

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created August 16, 2019 at 11:20 AM
Updated January 3, 2020 at 2:34 PM
Resolved October 14, 2019 at 8:30 PM
TestRail: Cases
TestRail: Runs