Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Replace ExtendedAsyncResult by AsyncResult where possible

Description

When methods require a Handler<AsyncResult<T>>> parameter instead of Handler<ExtendedAsyncResult<T>>> parameter we can use existing AsyncResult based tools, for example Vertx' TestContext.asyncAssertSuccess.

This is possible because Okapi's ExtendedAsyncResult extends Vertx' AsyncResult:
https://github.com/folio-org/okapi/blob/v2.36.3/okapi-common/src/main/java/org/folio/okapi/common/ExtendedAsyncResult.java

Use if (result instanceof ExtendedAsyncResult) where access to ExtendedAsyncResult.getType() is needed. This may be provided by ExtendedAsyncResult.getType(AsyncResult).

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Adam DickmeissFebruary 24, 2022 at 2:52 PM
Edited

This was done as part of https://folio-org.atlassian.net/browse/OKAPI-875#icft=OKAPI-875 work. The class still exists in okapi-common and should be removed. See https://folio-org.atlassian.net/browse/OKAPI-1078#icft=OKAPI-1078.

Done

Details

Assignee

Reporter

Labels

Priority

Development Team

Core: Platform

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created February 24, 2020 at 1:03 PM
Updated March 10, 2022 at 9:19 PM
Resolved February 24, 2022 at 2:52 PM
TestRail: Cases
TestRail: Runs

Flag notifications